From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [Qemu-devel] [QEMU PATCH] block: Remove blk_attach_dev_legacy() / legacy_dev code Date: Tue, 22 Jan 2019 15:57:12 +0100 Message-ID: <0afc242e-65d9-5abb-2a95-e4952f0ee164@redhat.com> References: <1545149484-4929-1-git-send-email-thuth@redhat.com> <25d1e73d-ca73-9cb4-d959-8353f49f36b7@redhat.com> <20190122144617.GA5220@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1glxUM-0007O7-KP for xen-devel@lists.xenproject.org; Tue, 22 Jan 2019 14:57:18 +0000 In-Reply-To: <20190122144617.GA5220@localhost.localdomain> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Kevin Wolf Cc: Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , paul.durrant@citrix.com, Anthony Perard , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gMjAxOS0wMS0yMiAxNTo0NiwgS2V2aW4gV29sZiB3cm90ZToKPiBBbSAyMi4wMS4yMDE5IHVt IDE1OjE5IGhhdCBUaG9tYXMgSHV0aCBnZXNjaHJpZWJlbjoKPj4gT24gMjAxOC0xMi0xOCAxNzox MSwgVGhvbWFzIEh1dGggd3JvdGU6Cj4+PiBUaGUgbGFzdCB1c2VyIG9mIGJsa19hdHRhY2hfZGV2 X2xlZ2FjeSgpIGlzIHRoZSBjb2RlIGluIHhlbl9kaXNrLmMuCj4+PiBJdCBwYXNzZXMgYSBwb2lu dGVyIHRvIGEgWGVuQmxrRGV2IGFzIHNlY29uZCBwYXJhbWV0ZXIuIFhlbkJsa0Rldgo+Pj4gaXMg ZGVyaXZlZCBmcm9tIFhlbkRldmljZSB3aGljaCBpbiB0dXJuIGlzIGRlcml2ZWQgZnJvbSBEZXZp Y2VTdGF0ZQo+Pj4gc2luY2UgY29tbWl0IDNhNmM5MTcyYWM1OTUxZSAoInhlbjogY3JlYXRlIHFk ZXYgZm9yIGVhY2ggYmFja2VuZCBkZXZpY2UiKS4KPj4+IFRodXMgdGhlIGNvZGUgY2FuIGFsc28g c2ltcGx5IHVzZSBibGtfYXR0YWNoX2RldigpIHdpdGggYSBwb2ludGVyCj4+PiB0byB0aGUgRGV2 aWNlU3RhdGUgaW5zdGVhZC4KPj4+IFNvIHdlIGNhbiBmaW5hbGx5IHJlbW92ZSBhbGwgY29kZSBy ZWxhdGVkIHRvIHRoZSAibGVnYWN5X2RldiIgZmxhZywgdG9vLAo+Pj4gYW5kIHR1cm4gdGhlIHJl bGF0ZWQgInZvaWQgKiIgaW4gYmxvY2stYmFja2VuZC5jIGludG8gIkRldmljZVN0YXRlICoiCj4+ PiB0byBmaXggc29tZSBvZiB0aGUgcmVtYWluaW5nIFRPRE9zIHRoZXJlLgo+Pj4KPj4+IFNpZ25l ZC1vZmYtYnk6IFRob21hcyBIdXRoIDx0aHV0aEByZWRoYXQuY29tPgo+Pj4gLS0tCj4+PiAgTm90 ZTogSSBoYXZlbid0IHRlc3RlZCB0aGUgWGVuIGNvZGUgc2luY2UgSSBkb24ndCBoYXZlIGEgd29y a2luZyBYZW4KPj4+ICBpbnN0YWxsYXRpb24gYXQgaGFuZC4gSSdkIGFwcHJlY2lhdGUgaWYgc29t ZW9uZSBjb3VsZCBjaGVjayBpdC4uLgo+Pgo+PiBQaW5nPwo+IAo+IFRoaXMgbmVlZHMgYSByZWJh c2UuIHhlbl9kaXNrLmMgZG9lc24ndCBldmVuIGV4aXN0IGFueSBtb3JlIGFuZAo+IGJsa19hdHRh Y2hfZGV2X2xlZ2FjeSgpIGlzIHJlYWxseSBkZWFkIGNvZGUgbm93LgoKQWgsIGdyZWF0LCB0aGF0 IG1ha2VzIGl0IGV2ZW4gZWFzaWVyISBJJ2xsIHNlbmQgYSB2MiB0byByZW1vdmUgdGhlCnJlbWFp bmRlcnMuLi4KCiBUaG9tYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm1yM-0001lo-Ex for qemu-devel@nongnu.org; Tue, 22 Jan 2019 14:44:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm1yL-0003Dn-OH for qemu-devel@nongnu.org; Tue, 22 Jan 2019 14:44:34 -0500 References: <1545149484-4929-1-git-send-email-thuth@redhat.com> <25d1e73d-ca73-9cb4-d959-8353f49f36b7@redhat.com> <20190122144617.GA5220@localhost.localdomain> From: Thomas Huth Message-ID: <0afc242e-65d9-5abb-2a95-e4952f0ee164@redhat.com> Date: Tue, 22 Jan 2019 15:57:12 +0100 MIME-Version: 1.0 In-Reply-To: <20190122144617.GA5220@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU PATCH] block: Remove blk_attach_dev_legacy() / legacy_dev code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, Max Reitz , Stefano Stabellini , Anthony Perard , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, paul.durrant@citrix.com On 2019-01-22 15:46, Kevin Wolf wrote: > Am 22.01.2019 um 15:19 hat Thomas Huth geschrieben: >> On 2018-12-18 17:11, Thomas Huth wrote: >>> The last user of blk_attach_dev_legacy() is the code in xen_disk.c. >>> It passes a pointer to a XenBlkDev as second parameter. XenBlkDev >>> is derived from XenDevice which in turn is derived from DeviceState >>> since commit 3a6c9172ac5951e ("xen: create qdev for each backend device"). >>> Thus the code can also simply use blk_attach_dev() with a pointer >>> to the DeviceState instead. >>> So we can finally remove all code related to the "legacy_dev" flag, too, >>> and turn the related "void *" in block-backend.c into "DeviceState *" >>> to fix some of the remaining TODOs there. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> Note: I haven't tested the Xen code since I don't have a working Xen >>> installation at hand. I'd appreciate if someone could check it... >> >> Ping? > > This needs a rebase. xen_disk.c doesn't even exist any more and > blk_attach_dev_legacy() is really dead code now. Ah, great, that makes it even easier! I'll send a v2 to remove the remainders... Thomas