From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4 Date: Thu, 31 Jan 2013 14:25:49 -0800 Message-ID: <0aff01ce0001$edc8f320$c95ad960$@samsung.com> References: <1359110384-28402-1-git-send-email-rahul.sharma@samsung.com> <1359110384-28402-2-git-send-email-rahul.sharma@samsung.com> <51059402.2030405@gmail.com> <5108344D.4090202@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:20525 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755812Ab3AaWZ7 (ORCPT ); Thu, 31 Jan 2013 17:25:59 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MHI000H0GZ9H9A0@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 01 Feb 2013 07:25:57 +0900 (KST) Received: from visitor4lab ([105.128.18.157]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MHI00440GZ6YK20@mmp1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 01 Feb 2013 07:25:57 +0900 (KST) In-reply-to: Content-language: en-us Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Rahul Sharma' , 'Sylwester Nawrocki' Cc: 'Rahul Sharma' , linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, inki.dae@samsung.com, joshi@samsung.com, 'Tomasz Stanislawski' , 'Tomasz Figa' , thomas.ab@samsung.com Rahul Sharma wrote: [...] > >>>> + hdmi { > >>>> + compatible = "samsung,exynos4-hdmi14"; > >>> > >>> > >>> > >>> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this > >>> compatible property is supposed to apply ? > >>> > >> > >> -hdmi14 signifies 1.4 compliant Hdmi IP like in Exynos4412, while > >> Exynos4210 has 1.3 > >> compliant HDMI block. I have done a mistake here. I should have kept > >> it in 4412.dtsi. OR > >> I can move it to 4x12.dtsi but not sure whether all 4x12 socs have 1.4 > >> hdmi. > > > > > > Exynos4210 also have the HDMI IP. I'm not sure how much common those > IP's > > are > > among Exynos4 series SoCs. I suppose it makes sense to create a hdmi > node in > > exynos4.dtsi and override what's required either in exynos4x12.dtsi or > > exynos4412.dtsi file. > > > > What is worring me is that you're trying to just append the supported > > HDMI standard version to the string, and there might be more differences > > in the IPs across all Exynos4 SoC series. What if there are two different > > SoCs that support e.g. HDMI v1.4 but there are some differences in the > > HDMI IPs ? You would likely need to invent new properties and pass them > > to the driver. Appending specific SoC name to the compatible string looks > > like a better alternative to me. > > > > I agree to it. Putting compatible string with first soc having the IP, > is a better > approach altogether. I will incorporate the change in next version. > Well, in this case, why should we use the SoC name? If just we need specific name here. I think, putting SoC name in compatible is a way to identify and when the version of IP is available, we can the version instead...like following, as some guy said before. compatible = "samsung,hdmi-1.4" If there is for hdmi 1.4a, compatible = "samsung,hdmi-1.4a" Thanks. - Kukjin