From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC629C77B79 for ; Mon, 17 Apr 2023 14:13:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231171AbjDQONs convert rfc822-to-8bit (ORCPT ); Mon, 17 Apr 2023 10:13:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231139AbjDQONp (ORCPT ); Mon, 17 Apr 2023 10:13:45 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 950D686AC; Mon, 17 Apr 2023 07:13:42 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-002HuW-Kt; Mon, 17 Apr 2023 16:13:35 +0200 Received: from p5b13a017.dip0.t-ipconnect.de ([91.19.160.23] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-0043co-Cy; Mon, 17 Apr 2023 16:13:35 +0200 Message-ID: <0b07fbadce4512e4696750cf69cf3fbbf38355a3.camel@physik.fu-berlin.de> Subject: Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers From: John Paul Adrian Glaubitz To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Yoshinori Sato , Rich Felker Date: Mon, 17 Apr 2023 16:13:33 +0200 In-Reply-To: <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-17-tzimmermann@suse.de> <3c188e948506dc97112dcc070cf16e36209c6cc5.camel@physik.fu-berlin.de> <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.160.23 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: > Hi > > Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: > > Hi Thomas! > > > > On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > > > Replace the architecture's fbdev helpers with the generic > > > ones from . No functional changes. > > > > > > v2: > > > * use default implementation for fb_pgprotect() (Arnd) > > > > > > Signed-off-by: Thomas Zimmermann > > > Cc: Yoshinori Sato > > > Cc: Rich Felker > > > Cc: John Paul Adrian Glaubitz > > > --- > > > arch/sh/include/asm/fb.h | 15 +-------------- > > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > > > diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h > > > index 9a0bca2686fd..19df13ee9ca7 100644 > > > --- a/arch/sh/include/asm/fb.h > > > +++ b/arch/sh/include/asm/fb.h > > > @@ -2,19 +2,6 @@ > > > #ifndef _ASM_FB_H_ > > > #define _ASM_FB_H_ > > > > > > -#include > > > -#include > > > -#include > > > - > > > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > > > - unsigned long off) > > > -{ > > > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > > > -} > > > > Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being replaced with > > a no-op function. Is that intentional? Can you briefly explain the background > > for this change? > > Patch 01 of this patchset changes the generic fb_pgprotect() to set > pgprot_writecombine(). So on SH, there should be no change at all. > Ah, I missed that, thanks for the explanation. Let me check and Ack your patch then. I assume you will be taking this patch as part of the whole series through your own tree? Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Paul Adrian Glaubitz Date: Mon, 17 Apr 2023 14:13:33 +0000 Subject: Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers Message-Id: <0b07fbadce4512e4696750cf69cf3fbbf38355a3.camel@physik.fu-berlin.de> List-Id: References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-17-tzimmermann@suse.de> <3c188e948506dc97112dcc070cf16e36209c6cc5.camel@physik.fu-berlin.de> <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> In-Reply-To: <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Yoshinori Sato , Rich Felker Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: > Hi > > Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: > > Hi Thomas! > > > > On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > > > Replace the architecture's fbdev helpers with the generic > > > ones from . No functional changes. > > > > > > v2: > > > * use default implementation for fb_pgprotect() (Arnd) > > > > > > Signed-off-by: Thomas Zimmermann > > > Cc: Yoshinori Sato > > > Cc: Rich Felker > > > Cc: John Paul Adrian Glaubitz > > > --- > > > arch/sh/include/asm/fb.h | 15 +-------------- > > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > > > diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h > > > index 9a0bca2686fd..19df13ee9ca7 100644 > > > --- a/arch/sh/include/asm/fb.h > > > +++ b/arch/sh/include/asm/fb.h > > > @@ -2,19 +2,6 @@ > > > #ifndef _ASM_FB_H_ > > > #define _ASM_FB_H_ > > > > > > -#include > > > -#include > > > -#include > > > - > > > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > > > - unsigned long off) > > > -{ > > > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > > > -} > > > > Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being replaced with > > a no-op function. Is that intentional? Can you briefly explain the background > > for this change? > > Patch 01 of this patchset changes the generic fb_pgprotect() to set > pgprot_writecombine(). So on SH, there should be no change at all. > Ah, I missed that, thanks for the explanation. Let me check and Ack your patch then. I assume you will be taking this patch as part of the whole series through your own tree? Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 925D0C77B76 for ; Mon, 17 Apr 2023 14:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fZvuZvCyLnNS0s1kK3S5bLdRAB/BFL8lb1U4QzPiQFI=; b=QrQgQnwE1eUL1D 8eoXXxyga9o/8cvLWUUSPz6QY+akuhGAnqcnGMbm2K4MJBaDXN8UL13dsF1OshigZXF+DASMoVlWL 9kG5Seho3fSOAXBB9bopSPgQvwq3nvukNuCLlakwgIy+lUJZsjq3AJlJzFa/dKRIjbUtSh60YbXIE FYqVSHg7C7hFX1CuqQipApYKy5+e/i+gdt7HEUONz0eMgX7BtDQbB9H78FVnlO8MwwaRN0EBsKnwE n4fP3aGHXhkY3fbuS1JRRtFlZgN9l9R0pvMpGROiEFNCrhnRcXLAmUqZ4VfcF9wMpNLCjo3AEMEGI tLkzK96/4Q1XWXxB7T2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poPcP-00GZEp-0D; Mon, 17 Apr 2023 14:14:09 +0000 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poPcM-00GZ5i-01; Mon, 17 Apr 2023 14:14:07 +0000 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-002HuW-Kt; Mon, 17 Apr 2023 16:13:35 +0200 Received: from p5b13a017.dip0.t-ipconnect.de ([91.19.160.23] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-0043co-Cy; Mon, 17 Apr 2023 16:13:35 +0200 Message-ID: <0b07fbadce4512e4696750cf69cf3fbbf38355a3.camel@physik.fu-berlin.de> Subject: Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers From: John Paul Adrian Glaubitz To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Yoshinori Sato , Rich Felker Date: Mon, 17 Apr 2023 16:13:33 +0200 In-Reply-To: <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-17-tzimmermann@suse.de> <3c188e948506dc97112dcc070cf16e36209c6cc5.camel@physik.fu-berlin.de> <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.160.23 X-ZEDAT-Hint: PO X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_071406_208175_23F994C2 X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: > Hi > > Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: > > Hi Thomas! > > > > On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > > > Replace the architecture's fbdev helpers with the generic > > > ones from . No functional changes. > > > > > > v2: > > > * use default implementation for fb_pgprotect() (Arnd) > > > > > > Signed-off-by: Thomas Zimmermann > > > Cc: Yoshinori Sato > > > Cc: Rich Felker > > > Cc: John Paul Adrian Glaubitz > > > --- > > > arch/sh/include/asm/fb.h | 15 +-------------- > > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > > > diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h > > > index 9a0bca2686fd..19df13ee9ca7 100644 > > > --- a/arch/sh/include/asm/fb.h > > > +++ b/arch/sh/include/asm/fb.h > > > @@ -2,19 +2,6 @@ > > > #ifndef _ASM_FB_H_ > > > #define _ASM_FB_H_ > > > > > > -#include > > > -#include > > > -#include > > > - > > > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > > > - unsigned long off) > > > -{ > > > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > > > -} > > > > Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being replaced with > > a no-op function. Is that intentional? Can you briefly explain the background > > for this change? > > Patch 01 of this patchset changes the generic fb_pgprotect() to set > pgprot_writecombine(). So on SH, there should be no change at all. > Ah, I missed that, thanks for the explanation. Let me check and Ack your patch then. I assume you will be taking this patch as part of the whole series through your own tree? Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36D67C77B76 for ; Mon, 17 Apr 2023 14:14:23 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Q0TZP5M5Wz3cMh for ; Tue, 18 Apr 2023 00:14:21 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=zedat.fu-berlin.de (client-ip=130.133.4.66; helo=outpost1.zedat.fu-berlin.de; envelope-from=glaubitz@zedat.fu-berlin.de; receiver=) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Q0TYs6bF6z3cMh for ; Tue, 18 Apr 2023 00:13:53 +1000 (AEST) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-002HuW-Kt; Mon, 17 Apr 2023 16:13:35 +0200 Received: from p5b13a017.dip0.t-ipconnect.de ([91.19.160.23] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-0043co-Cy; Mon, 17 Apr 2023 16:13:35 +0200 Message-ID: <0b07fbadce4512e4696750cf69cf3fbbf38355a3.camel@physik.fu-berlin.de> Subject: Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers From: John Paul Adrian Glaubitz To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Date: Mon, 17 Apr 2023 16:13:33 +0200 In-Reply-To: <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-17-tzimmermann@suse.de> <3c188e948506dc97112dcc070cf16e36209c6cc5.camel@physik.fu-berlin.de> <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.160.23 X-ZEDAT-Hint: PO X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, Rich Felker , linux-ia64@vger.kernel.org, Yoshinori Sato , linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: > Hi >=20 > Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: > > Hi Thomas! > >=20 > > On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > > > Replace the architecture's fbdev helpers with the generic > > > ones from . No functional changes. > > >=20 > > > v2: > > > * use default implementation for fb_pgprotect() (Arnd) > > >=20 > > > Signed-off-by: Thomas Zimmermann > > > Cc: Yoshinori Sato > > > Cc: Rich Felker > > > Cc: John Paul Adrian Glaubitz > > > --- > > > arch/sh/include/asm/fb.h | 15 +-------------- > > > 1 file changed, 1 insertion(+), 14 deletions(-) > > >=20 > > > diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h > > > index 9a0bca2686fd..19df13ee9ca7 100644 > > > --- a/arch/sh/include/asm/fb.h > > > +++ b/arch/sh/include/asm/fb.h > > > @@ -2,19 +2,6 @@ > > > #ifndef _ASM_FB_H_ > > > #define _ASM_FB_H_ > > > =20 > > > -#include > > > -#include > > > -#include > > > - > > > -static inline void fb_pgprotect(struct file *file, struct vm_area_st= ruct *vma, > > > - unsigned long off) > > > -{ > > > - vma->vm_page_prot =3D pgprot_writecombine(vma->vm_page_prot); > > > -} > >=20 > > Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being repla= ced with > > a no-op function. Is that intentional? Can you briefly explain the back= ground > > for this change? >=20 > Patch 01 of this patchset changes the generic fb_pgprotect() to set=20 > pgprot_writecombine(). So on SH, there should be no change at all. >=20 Ah, I missed that, thanks for the explanation. Let me check and Ack your pa= tch then. I assume you will be taking this patch as part of the whole series th= rough your own tree? Thanks, Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF57DC77B76 for ; Mon, 17 Apr 2023 14:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TONvqY7yaCxeXRz4dOvxPJWJfpAgWYmZ3LZUDkGzgKA=; b=aiXdo31qXRRbQw Cn5ngSgfIygx+1xHXfte7JodBKks57HgYVbvyrMZLHLpSGUKxk6FfJOeAv/A7DfPTHScPxh92mOm8 pbvUyKEEyBIA5N4Z2VjNBPkQ6Ae2GErNOJe2vbnuFK7IXispWrHRy6WHOhw24DvnCj2GXAsLVahtX W16DsyNyd/3Gcn1jh0hWCuhBvO8lsE5u8dwIgHgTl3JN0pgnhcDkTvigFY9cy3dcETT+cL8PbqGj8 1WfR170109Ic1J61G0SNIJNFDsztFJ5Ne29M7DDHv+84r80hdHfxd1QxzyamDEErbWKXNa6yO7cqn acTv/ge0yUk85Thahe9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poPcP-00GZF0-1c; Mon, 17 Apr 2023 14:14:09 +0000 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poPcM-00GZ5i-01; Mon, 17 Apr 2023 14:14:07 +0000 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-002HuW-Kt; Mon, 17 Apr 2023 16:13:35 +0200 Received: from p5b13a017.dip0.t-ipconnect.de ([91.19.160.23] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1poPbr-0043co-Cy; Mon, 17 Apr 2023 16:13:35 +0200 Message-ID: <0b07fbadce4512e4696750cf69cf3fbbf38355a3.camel@physik.fu-berlin.de> Subject: Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers From: John Paul Adrian Glaubitz To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Yoshinori Sato , Rich Felker Date: Mon, 17 Apr 2023 16:13:33 +0200 In-Reply-To: <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-17-tzimmermann@suse.de> <3c188e948506dc97112dcc070cf16e36209c6cc5.camel@physik.fu-berlin.de> <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de> User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.160.23 X-ZEDAT-Hint: PO X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_071406_208175_23F994C2 X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: > Hi > > Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: > > Hi Thomas! > > > > On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > > > Replace the architecture's fbdev helpers with the generic > > > ones from . No functional changes. > > > > > > v2: > > > * use default implementation for fb_pgprotect() (Arnd) > > > > > > Signed-off-by: Thomas Zimmermann > > > Cc: Yoshinori Sato > > > Cc: Rich Felker > > > Cc: John Paul Adrian Glaubitz > > > --- > > > arch/sh/include/asm/fb.h | 15 +-------------- > > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > > > diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h > > > index 9a0bca2686fd..19df13ee9ca7 100644 > > > --- a/arch/sh/include/asm/fb.h > > > +++ b/arch/sh/include/asm/fb.h > > > @@ -2,19 +2,6 @@ > > > #ifndef _ASM_FB_H_ > > > #define _ASM_FB_H_ > > > > > > -#include > > > -#include > > > -#include > > > - > > > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > > > - unsigned long off) > > > -{ > > > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > > > -} > > > > Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being replaced with > > a no-op function. Is that intentional? Can you briefly explain the background > > for this change? > > Patch 01 of this patchset changes the generic fb_pgprotect() to set > pgprot_writecombine(). So on SH, there should be no change at all. > Ah, I missed that, thanks for the explanation. Let me check and Ack your patch then. I assume you will be taking this patch as part of the whole series through your own tree? Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel