All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
	Jonathan Bell <jonathan@raspberrypi.org>,
	Phil Elwell <phil@raspberrypi.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Philipp Rosenberger <p.rosenberger@kunbus.com>,
	Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Peter Chen <peter.chen@kernel.org>
Subject: Re: [PATCH v2 00/10] Multi-segment Event Ring support for XHCI
Date: Fri, 1 Sep 2023 15:40:00 +0300	[thread overview]
Message-ID: <0b1591f2-4f4b-e3be-ee5f-bf8fe5e779f3@linux.intel.com> (raw)
In-Reply-To: <cover.1692892942.git.lukas@wunner.de>

On 24.8.2023 19.15, Lukas Wunner wrote:
> Enlarge the XHCI Event Ring to cope with high load situations
> by allowing more than one segment.
> 
> This second iteration seeks to address all of Mathias' review feedback on v1:
> 
> * Patch [01/10]:
>    Use ERST_DESI_MASK instead of ERST_PTR_MASK when constructing the new
>    ERDP value to avoid carrying over a set EHB bit.
> 
> * Patch [04/10]:
>    Only use up to 2 Event Ring segments by default (instead of 8).
> 
> * Patch [05/10]:
>    New patch to adjust segment numbers after ring expansion.
> 
> * Patch [08/10]:
>    New patch to clean up ERST_PTR_MASK inversion.
> 
> Several other issues caught my eye and I'm including fixes and cleanups
> for those as well.
> 

Thanks for working on this.

Tested this series with a forced transfer ring expansion and all worked well.

I'll add this internally first and then later send it forward after the merge window.

Thanks
Mathias


      parent reply	other threads:[~2023-09-01 12:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 16:15 [PATCH v2 00/10] Multi-segment Event Ring support for XHCI Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 01/10] xhci: Clear EHB bit only at end of interrupt handler Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 02/10] xhci: Preserve RsvdP bits in ERSTBA register correctly Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 03/10] xhci: Set DESI bits in ERDP " Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 04/10] xhci: Use more than one Event Ring segment Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 05/10] xhci: Adjust segment numbers after ring expansion Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 06/10] xhci: Update last segment pointer after Event Ring expansion Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 07/10] xhci: Expose segment numbers in debugfs Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 08/10] xhci: Clean up ERST_PTR_MASK inversion Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 09/10] xhci: Clean up stale comment on ERST_SIZE macro Lukas Wunner
2023-08-24 16:15 ` [PATCH v2 10/10] xhci: Clean up xhci_{alloc,free}_erst() declarations Lukas Wunner
2023-09-01 12:40 ` Mathias Nyman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b1591f2-4f4b-e3be-ee5f-bf8fe5e779f3@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathan@raspberrypi.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mathias.nyman@intel.com \
    --cc=nsaenz@kernel.org \
    --cc=p.rosenberger@kunbus.com \
    --cc=peter.chen@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.