All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>, autofs@vger.kernel.org
Cc: lidong.zhong@suse.com
Subject: Re: Unable to set log priority for all direct mounts
Date: Fri, 15 May 2026 21:59:20 +0800	[thread overview]
Message-ID: <0b19868a-a3f0-44fb-856c-1d3464b080a2@themaw.net> (raw)
In-Reply-To: <agYonWw9_WVrWyub@zuko.lan>

On 15/5/26 04:01, Goldwyn Rodrigues wrote:
> Hello,
>
> Since the work to have a single FIFO file for setting log priority
> (16ea4156 ("autofs-5.1.8 - switch to application wide command pipe"), to
> be more precise 16ea4156 (autofs-5.1.8 - switch to application wide
> command pipe), automount has lost the ability to set the log priority of
> all direct mounts using the path "/-".
>
>
> # sudo automount -l info /-
> Could not find device id for mount /-
>
> This is because automount attempts to mount and get verifies the real
> path which is non-existent in case of direct mounts "/-".

Of course yes.


>
> In the automount program, the log priority is set pretty early and much
> before the master map is setup. So we cannot check on the autofs dev
> either.

But it should be settable on a per-mount basis.

The command line log setting was always meant to modify an existing

global log priority. Setting it for /- should mean setting it for

all direct mounts, ie. the global setting.


>
> What would be the best way to solve this? Should we just document it
> as a feature loss?

It sounds more like a regression, I'd rather try and fix it.


There should be (is/used to be?) a global log priority for both direct

and indirect mounts which shouldn't need this sort of validation and

should be used if the validation fails.


Let me have a look and get back.


Ian


      reply	other threads:[~2026-05-15 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 20:01 Unable to set log priority for all direct mounts Goldwyn Rodrigues
2026-05-15 13:59 ` Ian Kent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b19868a-a3f0-44fb-856c-1d3464b080a2@themaw.net \
    --to=raven@themaw.net \
    --cc=autofs@vger.kernel.org \
    --cc=lidong.zhong@suse.com \
    --cc=rgoldwyn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.