All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Zihuan Zhang <zhangzihuan@kylinos.cn>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, mario.limonciello@amd.com,
	rafael@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] ACPI: video: Fix missing backlight node creation on
Date: Thu, 18 Sep 2025 09:33:51 +0200	[thread overview]
Message-ID: <0b214249-958c-4e14-a4d8-512f1d90dff4@kernel.org> (raw)
In-Reply-To: <f6afc998-f11e-4aac-a190-fbadb97e2d0c@kylinos.cn>

Hi Zihuan,

On 18-Sep-25 2:36 AM, Zihuan Zhang wrote:
> 
> 在 2025/9/12 18:35, Zihuan Zhang 写道:
>>> 1. There must be a GPU driver for these laptops somewhere?
>>> Even if out of tree using a laptop without a GPU these days
>>> just does not give a good user experience. So fix the GPU
>>> driver to call acpi_video_register_backlight().
>>>
>>> Note acpi_video_register_backlight() is deliberately exported
>>> without requiring the consuming out of tree kernel module to
>>> be GPL to allow this.
>>>
>>> Other options would be:
>>>
>>> 2. Add some special heuristics for Zhaoxin CPUs,
>>> the kernel already has a CPUID match mechanism for
>>> things like this. This could potentially be combined
>>> with a DMI system-vendor check to only do this special
>>> case handling on e.g. Lenovo and Inspur laptops.
>>>
>>> 3. Instead of adding the CPU-id based special case
>>> just outright use DMI quirks. In this case lets try
>>> to use substring matches to cover multiple models
>>> with a single entry so as to not grow the quirk
>>> table too much.
>>
>> Got it, thanks!
>>
>> In fact, we have tried a few approaches (cmdline option, CPU-ID based quirk, and DMI quirk),
>> and all of them work.
>> I will sync this information with Zhaoxin to see which way they prefer.
> 
> Zhaoxin has confirmed that they will handle this through their own GPU driver.

That is good to hear, thank you for the update.

Regards,

Hans




      reply	other threads:[~2025-09-18  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10  7:47 [PATCH v1] ACPI: video: Fix missing backlight node creation on Zhaoxin platforms Zihuan Zhang
2025-09-10  9:37 ` Hans de Goede
2025-09-10  9:58   ` Hans de Goede
2025-09-11  7:45     ` [PATCH v1] ACPI: video: Fix missing backlight node creation on Zihuan Zhang
2025-09-11 10:38       ` Hans de Goede
2025-09-12  1:11         ` Zihuan Zhang
2025-09-12  8:59           ` Hans de Goede
2025-09-12 10:35             ` Zihuan Zhang
2025-09-18  0:36               ` Zihuan Zhang
2025-09-18  7:33                 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b214249-958c-4e14-a4d8-512f1d90dff4@kernel.org \
    --to=hansg@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=zhangzihuan@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.