From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C510DCE7B04 for ; Thu, 28 Sep 2023 06:53:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.609277.948258 (Exim 4.92) (envelope-from ) id 1qlktE-0000zg-EK; Thu, 28 Sep 2023 06:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 609277.948258; Thu, 28 Sep 2023 06:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qlktE-0000zZ-As; Thu, 28 Sep 2023 06:52:48 +0000 Received: by outflank-mailman (input) for mailman id 609277; Thu, 28 Sep 2023 06:52:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qlktD-0000zT-IR for xen-devel@lists.xenproject.org; Thu, 28 Sep 2023 06:52:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a13eaba6-5dcb-11ee-878a-cb3800f73035; Thu, 28 Sep 2023 08:52:46 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 7AF004EE0738; Thu, 28 Sep 2023 08:52:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a13eaba6-5dcb-11ee-878a-cb3800f73035 MIME-Version: 1.0 Date: Thu, 28 Sep 2023 08:52:45 +0200 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, Simone Ballarin , Doug Goldstein , Henry Wang Subject: Re: [XEN PATCH v2 3/3] automation/eclair: build docs/misra to address MISRA C:2012 Dir 4.1 In-Reply-To: <14f44178655243a94ad3e51a72281637@bugseng.com> References: <14f44178655243a94ad3e51a72281637@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <0b5ff4ad22f42622befbdaf5ef3a9ae2@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 27/09/2023 15:29, Nicola Vetrini wrote: > On 27/09/2023 11:52, Nicola Vetrini wrote: >> The documentation pertaining Directive 4.1 is contained in docs/misra. >> The build script driving the analysis is amended to allow ECLAIR to >> analyze such file. >> >> Signed-off-by: Nicola Vetrini >> --- >> Changes in v2: >> - removed useless make flags >> --- >> automation/eclair_analysis/build.sh | 6 +++--- >> automation/eclair_analysis/prepare.sh | 4 ++-- >> 2 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/automation/eclair_analysis/build.sh >> b/automation/eclair_analysis/build.sh >> index ec087dd822fa..ea7a1e5a59b0 100755 >> --- a/automation/eclair_analysis/build.sh >> +++ b/automation/eclair_analysis/build.sh >> @@ -34,11 +34,11 @@ else >> fi >> >> ( >> - cd xen >> - >> + make -C docs misra >> make "-j${PROCESSORS}" "-l${PROCESSORS}.0" \ >> "CROSS_COMPILE=${CROSS_COMPILE}" \ >> "CC=${CROSS_COMPILE}gcc-12" \ >> "CXX=${CROSS_COMPILE}g++-12" \ >> - "XEN_TARGET_ARCH=${XEN_TARGET_ARCH}" >> + "XEN_TARGET_ARCH=${XEN_TARGET_ARCH}" \ >> + -C xen >> ) >> diff --git a/automation/eclair_analysis/prepare.sh >> b/automation/eclair_analysis/prepare.sh >> index 0cac5eba00ae..ebd5a2dde676 100755 >> --- a/automation/eclair_analysis/prepare.sh >> +++ b/automation/eclair_analysis/prepare.sh >> @@ -35,8 +35,8 @@ else >> fi >> >> ( >> - cd xen >> - cp "${CONFIG_FILE}" .config >> + ./configure >> + cp "${CONFIG_FILE}" xen/.config >> make clean >> find . -type f -name "*.safparse" -print -delete >> make -f ${script_dir}/Makefile.prepare prepare > > Hi, I observed a failure when running the analysis job of this series > through patchew, so > I think it's a good idea to put this patch on hold until I've figured > out what's wrong. > Sorry for the inconvenience. I found the culprit; there is a minor issue with patches 2/3 and 3/3. I'll submit a new one and address the other review comments as well. The changes will be minimal, so perhaps I will be able to retain the R-by-s. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)