From: Ping-Ke Shih <pkshih@realtek.com>
To: Alastair D'Silva <alastair@d-silva.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@kernel.org>
Cc: Luka Gejak <luka.gejak@linux.dev>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Ulf Hansson <ulfh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH rtw-next v4 3/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm
Date: Tue, 6 Oct 2026 02:05:47 +0000 [thread overview]
Message-ID: <0b69a0e2d5b246f4a576640c07b8172b@realtek.com> (raw)
In-Reply-To: <20261005084849.3109337-4-alastair@d-silva.org>
Alastair D'Silva <alastair@d-silva.org> wrote:
> +static void rtw_sdio_handle_interrupt_3081(struct rtw_dev *rtwdev, u32 hisr)
> +{
> + struct rtw_sdio *rtwsdio = (struct rtw_sdio *)rtwdev->priv;
> +
> + rtw_sdio_disable_interrupt(rtwdev);
> + rtw_write32(rtwdev, REG_SDIO_HISR, hisr);
> +
> + if (hisr & REG_SDIO_HISR_TXERR)
> + rtw_sdio_tx_err_isr(rtwdev);
> + if (hisr & REG_SDIO_HISR_RX_REQUEST)
> + rtw_sdio_rx_isr(rtwdev);
> +
> + /* Unmasking HIMR re-asserts the IRQ line if new packets arrived */
> + if (rtwsdio->running)
I think here needs a lock
> + rtw_sdio_enable_interrupt(rtwdev);
> +}
> +
next prev parent reply other threads:[~2026-10-06 2:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 8:48 [PATCH rtw-next v4 0/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm Alastair D'Silva
2026-10-05 8:48 ` [PATCH rtw-next v4 1/4] wifi: rtw88: sdio: Handle allocation and read errors in rtw_sdio_rxfifo_recv Alastair D'Silva
2026-10-06 1:35 ` Ping-Ke Shih
2026-10-05 8:48 ` [PATCH rtw-next v4 2/4] wifi: rtw88: sdio: Track running state and cancel TX worker on stop Alastair D'Silva
2026-10-06 2:03 ` Ping-Ke Shih
2026-10-06 4:44 ` Luka Gejak
2026-10-06 14:03 ` Luka Gejak
2026-10-06 14:18 ` Luka Gejak
2026-10-07 1:26 ` Ping-Ke Shih
2026-10-07 4:37 ` Luka Gejak
2026-10-07 5:21 ` Luka Gejak
2026-10-07 6:18 ` Luka Gejak
2026-10-05 8:48 ` [PATCH rtw-next v4 3/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm Alastair D'Silva
2026-10-06 2:05 ` Ping-Ke Shih [this message]
2026-10-05 8:48 ` [PATCH rtw-next v4 4/4] wifi: rtw88: sdio: Split rtw_sdio_rx_isr into 8051 and 3081 variants Alastair D'Silva
2026-10-06 2:08 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b69a0e2d5b246f4a576640c07b8172b@realtek.com \
--to=pkshih@realtek.com \
--cc=alastair@d-silva.org \
--cc=jernej.skrabec@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=stable@vger.kernel.org \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.