From: Dave Hansen <dave.hansen@intel.com>
To: Wei Xu <weixugc@google.com>, Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
yang.shi@linux.alibaba.com, shy828301@gmail.com,
ying.huang@intel.com, Dan Williams <dan.j.williams@intel.com>,
david@redhat.com, osalvador@suse.de
Subject: Re: [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded
Date: Thu, 1 Apr 2021 16:21:52 -0700 [thread overview]
Message-ID: <0b6a58f6-630c-aaa0-b3e9-e486cc9ce5fc@intel.com> (raw)
In-Reply-To: <CAAPL-u-o-M2T25xBtSoipYjUnu+3aJNcJ9uS84yKaAnbrXpefw@mail.gmail.com>
On 4/1/21 3:35 PM, Wei Xu wrote:
> A small suggestion: Given that migrate_pages() requires that
> *nr_succeeded should be initialized to 0 when it is called due to its
> use of *nr_succeeded in count_vm_events() and trace_mm_migrate_pages(),
> it would be less error-prone if migrate_pages() initializes
> *nr_succeeded itself.
That's a good point, especially if a caller made multiple
migrate_pages() calls without resetting it, which a number of callers
do. That could really have caused some interesting problems. Thanks
for catching that!
I'll do what you suggested.
next prev parent reply other threads:[~2021-04-01 23:21 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:32 [PATCH 00/10] [v7][RESEND] Migrate Pages in lieu of discard Dave Hansen
2021-04-01 18:32 ` [PATCH 01/10] mm/numa: node demotion data structure and lookup Dave Hansen
2021-04-08 8:03 ` Oscar Salvador
2021-04-08 21:29 ` Dave Hansen
2021-04-09 5:32 ` Wei Xu
2021-04-01 18:32 ` [PATCH 02/10] mm/numa: automatically generate node migration order Dave Hansen
2021-04-08 8:26 ` Oscar Salvador
2021-04-08 21:51 ` Dave Hansen
2021-04-09 8:17 ` Oscar Salvador
2021-04-10 3:07 ` Wei Xu
2021-04-14 8:08 ` Oscar Salvador
2021-04-14 8:11 ` Oscar Salvador
2021-04-14 8:12 ` David Hildenbrand
2021-04-14 8:14 ` Oscar Salvador
2021-04-14 8:20 ` David Hildenbrand
2021-04-15 4:07 ` Wei Xu
2021-04-15 15:35 ` Dave Hansen
2021-04-15 20:25 ` Wei Xu
2021-04-01 18:32 ` [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events Dave Hansen
2021-04-08 9:52 ` Oscar Salvador
2021-04-09 10:14 ` Oscar Salvador
2021-04-09 10:15 ` Oscar Salvador
2021-04-09 18:59 ` David Hildenbrand
2021-04-12 7:19 ` Oscar Salvador
2021-04-12 9:19 ` David Hildenbrand
2021-04-01 18:32 ` [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-04-01 22:35 ` Wei Xu
2021-04-01 23:21 ` Dave Hansen [this message]
2021-04-01 22:39 ` Wei Xu
2021-04-08 10:14 ` Oscar Salvador
2021-04-08 17:26 ` Yang Shi
2021-04-08 18:17 ` Oscar Salvador
2021-04-08 18:21 ` Oscar Salvador
2021-04-08 20:40 ` Yang Shi
2021-04-09 5:06 ` Oscar Salvador
2021-04-09 5:43 ` Wei Xu
2021-04-09 15:43 ` Yang Shi
2021-04-09 15:50 ` Dave Hansen
2021-04-09 18:47 ` Wei Xu
2021-04-09 20:10 ` Yang Shi
2021-04-01 18:32 ` [PATCH 05/10] mm/migrate: demote pages during reclaim Dave Hansen
2021-04-01 20:01 ` Yang Shi
2021-04-01 22:58 ` Dave Hansen
2021-04-08 10:47 ` Oscar Salvador
2021-04-10 3:35 ` Wei Xu
2021-04-01 18:32 ` [PATCH 06/10] mm/vmscan: add page demotion counter Dave Hansen
2021-04-10 3:40 ` Wei Xu
2021-04-01 18:32 ` [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-04-07 18:40 ` Wei Xu
2021-04-09 8:31 ` Oscar Salvador
2021-04-01 18:32 ` [PATCH 08/10] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2021-04-02 0:55 ` Wei Xu
2021-04-01 18:32 ` [PATCH 09/10] mm/vmscan: never demote for memcg reclaim Dave Hansen
2021-04-02 0:18 ` Wei Xu
2021-04-01 18:32 ` [PATCH 10/10] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen
2021-04-01 20:06 ` Yang Shi
2021-04-10 4:10 ` Wei Xu
2021-04-16 12:35 ` [PATCH 00/10] [v7][RESEND] Migrate Pages in lieu of discard Michal Hocko
2021-04-16 14:26 ` Dave Hansen
2021-04-16 15:02 ` Michal Hocko
2021-04-21 2:39 ` Huang, Ying
2021-05-07 6:14 ` Huang, Ying
-- strict thread matches above, loose matches on Subject: below --
2021-03-04 23:59 [PATCH 00/10] [v6] " Dave Hansen
2021-03-04 23:59 ` [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-03-09 0:05 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b6a58f6-630c-aaa0-b3e9-e486cc9ce5fc@intel.com \
--to=dave.hansen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.