From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4152C433E0 for ; Tue, 9 Mar 2021 16:21:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9B5F65237 for ; Tue, 9 Mar 2021 16:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbhCIQUk (ORCPT ); Tue, 9 Mar 2021 11:20:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhCIQUZ (ORCPT ); Tue, 9 Mar 2021 11:20:25 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2861EC06174A; Tue, 9 Mar 2021 08:20:25 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id kr3-20020a17090b4903b02900c096fc01deso5466649pjb.4; Tue, 09 Mar 2021 08:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WgrGh57osqWHsh+n9g0qjzJok3lMbDzItuhcBevpbd4=; b=YgRrrgCJ/qusSAHXcTwLZ1vFJR/5R9BL6Q2KG5xloEesaNyaOoabMp4/uwVf8KaMO3 6NhSZKinB7aBec5HuHQz1h/00uKo4MKYswLcDIrKx4kqmrTQzpEo4t2Jim1QgYlDTwV5 +NDk1aI1z0+eFxVGKh3n0fcAI5OfbvmKT2IaDT2Vlgd5A1UrPnO9+QrUGCS6SwDcxMYl ukzhl9qT0eQIi4iKt7nCeWboSsWL/f0S7gmLOFkUvjo1OfdsDDFaVhk2lWm4N34Y2jHc V+qzHEAiMm4NHWwhaqNC7qPEHijL0yowwEI423vT0NO0rO00N/iMFyf6PrKEgAJUUknt C22Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WgrGh57osqWHsh+n9g0qjzJok3lMbDzItuhcBevpbd4=; b=e8bivAbl60yPuV8xYtX41SLf/glGT59QcvC/bggYJXUAXG5aHLyI72kfeTmLdoTHtv z0xQTqEEq6EcKP+ezN2a0p2/C5TbbdySKg+KBEOzRQz9pTPLhlcMuZsUW3/u3QIes3oU nRRUZCxEuS9TbAQ7Y0nZX23qrc1V+Q6Tt/ASbLd49zuak9CPLIywVmjAzcErpomXhUL/ KNX8FUPCpRTERl8vZcHHqm/AMIJGDAR9lbTX1k/HFJLU4da1ZdWuF9B4H/zTRzTjDFse ETRY7vMfcqysCe60JIsTZM7AWlXvDKoMdRkFYnr/CPIhtD6kwCphRgd4kn/05LyxAmKH WwRA== X-Gm-Message-State: AOAM533TiCAxWp6FE66BPzr4VjVlo0Z+65P4uTkug3HRwHJVLFhP2Jd7 cGEz9aVFbBWmtSsmTyumxng= X-Google-Smtp-Source: ABdhPJwCoIr6XFd4uEWpJCIcqsJ93yGswQ67+USwpdzNTIRbWzvpdzW4nQEc98JhyJMb7/OzbTCGZg== X-Received: by 2002:a17:90a:cca:: with SMTP id 10mr5377993pjt.103.1615306824658; Tue, 09 Mar 2021 08:20:24 -0800 (PST) Received: from [172.30.1.19] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id w84sm8279705pfc.142.2021.03.09.08.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 08:20:24 -0800 (PST) Subject: Re: [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats To: Dong Aisheng , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, abel.vesa@nxp.com References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com> From: Chanwoo Choi Message-ID: <0b6ceb75-040f-8e1c-73ea-9d60344b9918@gmail.com> Date: Wed, 10 Mar 2021 01:20:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > Check .get_dev_status() in devfreq_update_stats in case it's abused > when a device does not provide it. > > Signed-off-by: Dong Aisheng > --- > drivers/devfreq/governor.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h > index 31af6d072a10..67a6dbdd5d23 100644 > --- a/drivers/devfreq/governor.h > +++ b/drivers/devfreq/governor.h > @@ -89,6 +89,9 @@ int devfreq_update_target(struct devfreq *devfreq, unsigned long freq); > > static inline int devfreq_update_stats(struct devfreq *df) > { > + if (!df->profile->get_dev_status) > + return -EINVAL; > + I'm considering the following method instead of returning the error when .get_dev_status is NULL. if (!df->profile->get_dev_status) { df->last_status.total_time = 0; df->last_status.busy_time = 0; df->last_status.current_frequency = 0; return 0; } > return df->profile->get_dev_status(df->dev.parent, &df->last_status); > } > #endif /* _GOVERNOR_H */ > -- Best Regards, Samsung Electronics Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FB0C433DB for ; Tue, 9 Mar 2021 16:22:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1825065238 for ; Tue, 9 Mar 2021 16:22:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1825065238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MdIYVCU2nEe1wTV7io7hRaRhd+kkduvOK8JZ2A+A3JE=; b=nXzCqCRw5BWJeiqm4rUs+2gLR TDDRijNhOqJcgeFhJXgxxbqAxWKWwHEI0X1Xb+X42RHnbq3A5PHnXDA7bmpR0ssmtTVRDa4IZXmfO UFL3CySga3L6QULyq0QrDprUK+kdUvn3rBlEaihEjtVDUFmGfs9VSjxxAyYdB636LUFegmNSTVjAI TP+TP0LqRV6n97ui3yrFR/7odkM+r78As24llcNuqjrAXGKcNiJyA09LXdNhfOa7KdRhO8oan02kK c/trdQnjdY91XlN6agGHaoxxe8KVg5IpEg+rjV3z9CWlQxKo1BBA5qwaTZwhAMhQ5PW9KD2stvm8A KdTkc1kkQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJf5z-0053vN-Pw; Tue, 09 Mar 2021 16:20:31 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJf5v-0053uo-Ac for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 16:20:29 +0000 Received: by mail-pj1-x102b.google.com with SMTP id mz6-20020a17090b3786b02900c16cb41d63so5470651pjb.2 for ; Tue, 09 Mar 2021 08:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WgrGh57osqWHsh+n9g0qjzJok3lMbDzItuhcBevpbd4=; b=YgRrrgCJ/qusSAHXcTwLZ1vFJR/5R9BL6Q2KG5xloEesaNyaOoabMp4/uwVf8KaMO3 6NhSZKinB7aBec5HuHQz1h/00uKo4MKYswLcDIrKx4kqmrTQzpEo4t2Jim1QgYlDTwV5 +NDk1aI1z0+eFxVGKh3n0fcAI5OfbvmKT2IaDT2Vlgd5A1UrPnO9+QrUGCS6SwDcxMYl ukzhl9qT0eQIi4iKt7nCeWboSsWL/f0S7gmLOFkUvjo1OfdsDDFaVhk2lWm4N34Y2jHc V+qzHEAiMm4NHWwhaqNC7qPEHijL0yowwEI423vT0NO0rO00N/iMFyf6PrKEgAJUUknt C22Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WgrGh57osqWHsh+n9g0qjzJok3lMbDzItuhcBevpbd4=; b=ZBWMpuSC/baQEVd5C3qHz2Ufi3vwTf4XxNliUSo6Q92U3VcysC32U4lvV9e/PoXopc 80lz15QX7Ya3zbXzH4ROhyK39K3sTHMfdpIJkgxyHkVMnMbSo+sKCTf+/LbPtop/6eFi Nk0KB5sohihl6y0m3LeZaDUGO/QplgJzz/an9TXDZyyAEBIkpnktzqzC6Z6BoEjHr4zZ YOpW4eIHVr0mj37YplMBceLL7qklZXmOFjF0AclYsetqTdyIknUlz3rQFINVFGE03vKP 8j/84ckQtHlSWZjYq6Ezaxizfd7yaAhOIrxVlKB/XBR0iJPE/pKtyIYmdev+iylAQHYq jqcQ== X-Gm-Message-State: AOAM531wTKj/C2/dt1t6dfWmimGkRM76Ce9Dzi0IKe/44q5m/zEyMWn7 SeSRrKp53VPbFMpcFBCaXko= X-Google-Smtp-Source: ABdhPJwCoIr6XFd4uEWpJCIcqsJ93yGswQ67+USwpdzNTIRbWzvpdzW4nQEc98JhyJMb7/OzbTCGZg== X-Received: by 2002:a17:90a:cca:: with SMTP id 10mr5377993pjt.103.1615306824658; Tue, 09 Mar 2021 08:20:24 -0800 (PST) Received: from [172.30.1.19] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id w84sm8279705pfc.142.2021.03.09.08.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 08:20:24 -0800 (PST) Subject: Re: [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats To: Dong Aisheng , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, abel.vesa@nxp.com References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com> From: Chanwoo Choi Message-ID: <0b6ceb75-040f-8e1c-73ea-9d60344b9918@gmail.com> Date: Wed, 10 Mar 2021 01:20:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_162027_454363_C3F843D1 X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjEuIDMuIDkuIOyYpO2bhCA5OjU4LCBEb25nIEFpc2hlbmcgd3JvdGU6Cj4gQ2hlY2sgLmdl dF9kZXZfc3RhdHVzKCkgaW4gZGV2ZnJlcV91cGRhdGVfc3RhdHMgaW4gY2FzZSBpdCdzIGFidXNl ZAo+IHdoZW4gYSBkZXZpY2UgZG9lcyBub3QgcHJvdmlkZSBpdC4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBEb25nIEFpc2hlbmcgPGFpc2hlbmcuZG9uZ0BueHAuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9k ZXZmcmVxL2dvdmVybm9yLmggfCAzICsrKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9u cygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RldmZyZXEvZ292ZXJub3IuaCBiL2RyaXZl cnMvZGV2ZnJlcS9nb3Zlcm5vci5oCj4gaW5kZXggMzFhZjZkMDcyYTEwLi42N2E2ZGJkZDVkMjMg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yLmgKPiArKysgYi9kcml2ZXJz L2RldmZyZXEvZ292ZXJub3IuaAo+IEBAIC04OSw2ICs4OSw5IEBAIGludCBkZXZmcmVxX3VwZGF0 ZV90YXJnZXQoc3RydWN0IGRldmZyZXEgKmRldmZyZXEsIHVuc2lnbmVkIGxvbmcgZnJlcSk7Cj4g ICAKPiAgIHN0YXRpYyBpbmxpbmUgaW50IGRldmZyZXFfdXBkYXRlX3N0YXRzKHN0cnVjdCBkZXZm cmVxICpkZikKPiAgIHsKPiArCWlmICghZGYtPnByb2ZpbGUtPmdldF9kZXZfc3RhdHVzKQo+ICsJ CXJldHVybiAtRUlOVkFMOwo+ICsKCkknbSBjb25zaWRlcmluZyB0aGUgZm9sbG93aW5nIG1ldGhv ZCBpbnN0ZWFkIG9mIHJldHVybmluZyB0aGUgZXJyb3IKd2hlbiAuZ2V0X2Rldl9zdGF0dXMgaXMg TlVMTC4KCglpZiAoIWRmLT5wcm9maWxlLT5nZXRfZGV2X3N0YXR1cykgewoJCWRmLT5sYXN0X3N0 YXR1cy50b3RhbF90aW1lID0gMDsKCQlkZi0+bGFzdF9zdGF0dXMuYnVzeV90aW1lID0gMDsKCQlk Zi0+bGFzdF9zdGF0dXMuY3VycmVudF9mcmVxdWVuY3kgPSAwOwoJCXJldHVybiAwOwkKCX0JCgo+ ICAgCXJldHVybiBkZi0+cHJvZmlsZS0+Z2V0X2Rldl9zdGF0dXMoZGYtPmRldi5wYXJlbnQsICZk Zi0+bGFzdF9zdGF0dXMpOwo+ICAgfQo+ICAgI2VuZGlmIC8qIF9HT1ZFUk5PUl9IICovCj4gCgoK LS0gCkJlc3QgUmVnYXJkcywKU2Ftc3VuZyBFbGVjdHJvbmljcwpDaGFud29vIENob2kKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK