From: Kashyap Desai <kashyap.desai@broadcom.com>
To: Jens Axboe <axboe@kernel.dk>, John Garry <john.garry@huawei.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
hare@suse.de, ming.lei@redhat.com, linux-scsi@vger.kernel.org
Subject: RE: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags
Date: Thu, 9 Dec 2021 19:22:59 +0530 [thread overview]
Message-ID: <0b928f7dbc2f3244afe8a475b547157f@mail.gmail.com> (raw)
In-Reply-To: <163482611742.37241.15630114014516067630.b4-ty@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
+ scsi mailing list
> On Mon, 18 Oct 2021 17:41:23 +0800, John Garry wrote:
> > Since it is now possible for a tagset to share a single set of tags,
> > the iter function should not re-iter the tags for the count of #hw
> > queues in that case. Rather it should just iter once.
John - Recently we found issue of error hander thread never kicked off and
this patch fix the issue.
Without this patch, scsi error hander will not find correct host_busy
counter.
Take one simple case. There is one IO outstanding and that is getting
timedout.
Now SML wants to wake up EH thread only if, below condition met
"scsi_host_busy(shost) == shost->host_failed"
Without this patch, shared host tag enabled meagaraid_sas driver will find
host_busy = actual outstanding * nr_hw_queues.
Error handler thread will never be kicked-off.
This patch is mandatory for fixing shared host tag feature and require to be
part of stable kernel.
Do you need more data for posting to stable kernel ?
Kashyap
> >
> >
>
> Applied, thanks!
>
> [1/1] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags
> commit: 0994c64eb4159ba019e7fedc7ba0dd6a69235b40
>
> Best regards,
> --
> Jens Axboe
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2021-12-09 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 9:41 [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags John Garry
2021-10-18 18:49 ` Kashyap Desai
2021-10-21 8:08 ` John Garry
2021-10-21 14:21 ` Jens Axboe
2021-12-09 13:52 ` Kashyap Desai [this message]
2021-12-09 14:42 ` John Garry
2021-12-13 13:15 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b928f7dbc2f3244afe8a475b547157f@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.