From: Stefan Agner <stefan@agner.ch>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/fsl-dcu: Remove unneeded NULL check
Date: Mon, 28 Nov 2016 17:17:26 -0800 [thread overview]
Message-ID: <0b9900a671aa4b444956402fa754c04e@agner.ch> (raw)
In-Reply-To: <1479310713-15180-1-git-send-email-fabio.estevam@nxp.com>
On 2016-11-16 07:38, Fabio Estevam wrote:
> devm_ioremap_resource() performs NULL check for the 'res' argument,
> so remove the unneeded check.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> index 0b0d1cb..812a211 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> @@ -336,11 +336,6 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
> fsl_dev->soc = id->data;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "could not get memory IO resource\n");
> - return -ENODEV;
> - }
> -
> base = devm_ioremap_resource(dev, res);
> if (IS_ERR(base)) {
> ret = PTR_ERR(base);
Applied both to my for-next branch, thanks!
--
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-11-29 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 15:38 [PATCH 1/2] drm/fsl-dcu: Remove unneeded NULL check Fabio Estevam
2016-11-16 15:38 ` [PATCH 2/2] drm/fsl-dcu: Propagate the real error code Fabio Estevam
2016-11-29 1:17 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b9900a671aa4b444956402fa754c04e@agner.ch \
--to=stefan@agner.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.