From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07212C61DC2 for ; Tue, 25 Aug 2026 16:45:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyuGC-0005R1-9M; Tue, 25 Aug 2026 12:44:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyuGA-0005QI-Bu; Tue, 25 Aug 2026 12:44:26 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyuG8-0005Fb-Pn; Tue, 25 Aug 2026 12:44:26 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67PEYlgX010278; Tue, 25 Aug 2026 16:44:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=eKOhvn hgKh685HtG5rtQD0vAexgCTvtBY3a52hbR3SM=; b=T3uc5571MZ0Mjh+oKSz/++ UBj82xzLcXY2QSCcnzk9wTg9N3UJSUriCXS4ddnCbZLYsIS+rmrnoC1eHfpNemHb OjIg6oRkEcAtJ7nM4H/CPHReNsytJy9ZqgMzkmTwgnVWF6zlTDFxgV3wZZfGvQ/G x8dXdzjbcmIEH+vppMGXuLjmMdK373ws4P4OxXODPLHwj1BP6t5vsieYJBCu9Qdh eKBL3knFnDIBHmyA4SMv4BJh+7njT7e00+ZNpdQ545/GNbNp+LMXM+KHERYNxzOq FdFl6rfKkEaqTMCizQlNxMUfmjKgJE3xH7okIDgHlcizst3fYdPgmgXyvH4SzRGA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4g726ehc4n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2026 16:44:20 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67PGfFo8003324; Tue, 25 Aug 2026 16:44:19 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4g7ragd2d7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2026 16:44:19 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67PGiIQg59507044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Aug 2026 16:44:18 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B85F58055; Tue, 25 Aug 2026 16:44:18 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D8A885804E; Tue, 25 Aug 2026 16:44:17 +0000 (GMT) Received: from [9.12.79.241] (unknown [9.12.79.241]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 25 Aug 2026 16:44:17 +0000 (GMT) Message-ID: <0ba0a7aa-623a-48e3-bde9-48ee82331d1a@linux.ibm.com> Date: Tue, 25 Aug 2026 12:44:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] hw/s390x/ipl: Fix incorrect PCI IPL block length constant To: Eric Farman , jrossi@linux.ibm.com, qemu-devel@nongnu.org, qemu-s390x@nongnu.org, cohuck@redhat.com, mjrosato@linux.ibm.com References: <20260811144629.866641-1-jrossi@linux.ibm.com> <20260811144629.866641-3-jrossi@linux.ibm.com> <51730ac3-ff1f-4eca-98f9-b31b47596185@linux.ibm.com> <1bf6e2a3-be53-47b3-8694-9b249770a655@linux.ibm.com> Content-Language: en-US From: Zhuoying Cai In-Reply-To: <1bf6e2a3-be53-47b3-8694-9b249770a655@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=TfimcxQh c=1 sm=1 tr=0 ts=6a8dc664 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=i0Rv7IPlQtgOKCfQKW8A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDE0MSBTYWx0ZWRfX1lQacFAP0cz+ uAhkITPs+zwNtrM7W0LGOh0zZcznTf6p3vlgRxGEl6n9OQC8dWEs8zj7PehdVjYoi3nLymsoAYa 11w77bA8UlUyvn4LCBEsc1K3p1E1QhE= X-Proofpoint-GUID: 8yrk6n5bu4nhfWRNnIZ9eZ2jycMMdFv- X-Proofpoint-ORIG-GUID: 8yrk6n5bu4nhfWRNnIZ9eZ2jycMMdFv- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDE0MSBTYWx0ZWRfX571lnHgJalEs 9MAIYLZfiCYiEOwhLugbl/taycyzCL48rZb/DxzrioR/nq771N3G1BfIkte2MJw8IxTAw7Tui6q D8OMZ9hQ3RLPV/e+sqSoKwrYM1B+IG+DMqDdvsr7Q6VHPoHslhOc+jmZGlOD1AW9F+4qKitjBDg zFjDzQlHSRJM1MoFihDWBJK/zGZjIyGQjz8Eua50ek7MmThD8RDdzzupKVgxIVSdpGHIJlxAqKG qzWFwrC/oTURCN9ftusEddjMGnzwd3X2SErrkB/BvcPJW44S/X85IU39l4w+yADa/T+nZfb1M+N 2YI5J0WmS2nqGCARlOfg73KuP+y1rujIHMlFNtMQqAM21ZYZ3COeDqk9L5lt5wg0xeob0ZvEau+ vYni7UNy7zBzfaCD6K72CZZXEJ7IGw4Eurj+Gk+xYxMACAqHa8H8r0l2+bFoPlw+e4LQspDvs+W 6QzLc/TUNlJ7RQTw8EQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_04,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250141 Received-SPF: pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/25/26 6:29 AM, Eric Farman wrote: > > > On 8/24/26 1:53 PM, Zhuoying Cai wrote: >> On 8/11/26 10:46 AM, jrossi@linux.ibm.com wrote: >>> From: Jared Rossi >>> >>> The IplBlockPci struct is 336 bytes in length. >>> >> >> The commit message is slightly misleading because IplBlockPci itself is >> 312 bytes in length. >> >> Maybe reword it to something like: >> "IplBlockPci is 312 bytes, so the minimum PCI IPLB length is 336 bytes." >> > > Given that, should the #define be sizeof(IplBlockPci) + 24? > If IplBlockPci is likely to expand in the future, it might make sense to derive this value from the structure layout. For example, offsetof(IplParameterBlock, pci) + sizeof(IplBlockPci) could be more accurate. Otherwise, keeping it as a constant like the other definitions seems reasonable as well. > And does the patch itself need to be cc'd to stable? > >> Otherwise: >> Reviewed-by: Zhuoying Cai >> >>> Fix the S390_IPLB_MIN_PCI_LEN to reflect this, and assign a valid blk0_len >>> while we are at it. >>> >>> Signed-off-by: Jared Rossi >>> --- >>> hw/s390x/ipl.c | 2 ++ >>> hw/s390x/ipl.h | 2 +- >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c >>> index d5fdc3ea0f..fd6e9100f9 100644 >>> --- a/hw/s390x/ipl.c >>> +++ b/hw/s390x/ipl.c >>> @@ -526,6 +526,8 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb) >>> switch (devtype) { >>> case PCI_DEVTYPE_VIRTIO: >>> iplb->len = cpu_to_be32(S390_IPLB_MIN_PCI_LEN); >>> + iplb->blk0_len = >>> + cpu_to_be32(S390_IPLB_MIN_PCI_LEN - S390_IPLB_HEADER_LEN); >>> iplb->pbt = S390_IPL_TYPE_PCI; >>> iplb->pci.fid = cpu_to_be32(pbdev->fid); >>> break; >>> diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h >>> index fac30763df..b4d93054a7 100644 >>> --- a/hw/s390x/ipl.h >>> +++ b/hw/s390x/ipl.h >>> @@ -107,7 +107,7 @@ QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, "alignment of iplb wrong"); >>> #define S390_IPLB_MIN_PV_LEN 148 >>> #define S390_IPLB_MIN_CCW_LEN 200 >>> #define S390_IPLB_MIN_FCP_LEN 384 >>> -#define S390_IPLB_MIN_PCI_LEN 376 >>> +#define S390_IPLB_MIN_PCI_LEN 336 >>> #define S390_IPLB_MIN_QEMU_SCSI_LEN 200 >>> >>> static inline bool iplb_valid_len(IplParameterBlock *iplb) >> >