From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8087F2F9DA7 for ; Wed, 17 Sep 2025 23:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758152068; cv=none; b=hH9TBV+v8vcXlo4EKPINNHSEucqrnuIMLT1vaJ279uxm82E6ZMQDai4/YAGapBjXdBUpohn7yLKB4SgTXVdxzGj8WtEw4y2ojUoX+Ubb3SFuxbHqQQ18iDGCVMDitBcH9SGz5LplxNxDq6zZA5jteonnMa5/IbP1PysZFw0nj1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758152068; c=relaxed/simple; bh=swWyIN+1pJbbIQJJjvJgyKEibOYxD+xzaD2IMHdTwP8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q5AoiPYBtgbvlZwVDSk/uGH1kxqpwtOkprtNe0cBMY34gVUdzvkXeljm98mPrxuNUia+urR6zFq0Iv0WPY6QxTx4qD5pwP5MWcdnKTAHeTwFF5Lo9kGldm4HQXFvpKU84iXHKDKd83rMhEU+CbUE3nw0e/2W89lc0oOP6N8Pz4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=fHD3+5rY; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="fHD3+5rY" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7459fa1ef2aso373678a34.1 for ; Wed, 17 Sep 2025 16:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1758152063; x=1758756863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZKhBLhOoADNGhrD1cnDjjtM0fyI+xW8dSVMWE/99mqc=; b=fHD3+5rYdQXWtZN9ttp8ggQRDm5yDRxNlGHZ29cm1jgrrVij0JbCSmK/esV8CgIpux Q+nDMl4iBLq1wlsZN8GcwCWAMLzlMo9aV/xwpJ72mB4JYqXeYG7be/Ibumi5hzfAxzb9 bn/7GyZTLzOlLHvCn4lUkMBf9K7+I+0zl6ZiUcmQbV9JACLcLIIRjDgyT/vNisq+6dPb fQ6mf542fBi8iGUGKfVPIekKVaDHlMMgSrkcWmvmIhLQEnI33H1xyOFbbik7k+J95wTC 6uJslYfxMdeXj++VxJrISTGdtZ7AjumAYrk/TF0fGN/IgSCfKAd54l0zNt4q8EtFVjCD PADw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758152063; x=1758756863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZKhBLhOoADNGhrD1cnDjjtM0fyI+xW8dSVMWE/99mqc=; b=E8MJUHSOs4aw+Jri1fwcE1hL+2lobREbBZCM9uwnbX08Tnaecvb+rbWWEJvXwlMLak V/QEYgIhFC3KAaP3spVaog8LBHxPWgT+HTfato7zTwdqonmpj2XtFcBwGFR3zgFUP57L LhAI5rrqbEweXzCrqrOOhjCvksllHajW6Nbxwn9aQ0LFhYe7HxX5lQmSTZyOFpShNywl MAv+Fq+xfwkRowR7Rb4mtnGha8hTrCpPRrB6BFdCUGaygZV4uMr3JMOpxQ9LlMGSb+Pn cdoso78XTU4bUloW9KthpVEsn4uPkI9TLyyjX+ZpLeN+kjb2xTLwXc6h95TIiNOXZdV9 qw+A== X-Gm-Message-State: AOJu0YytLErQf0YEeFAJWdLFYcfbyiKnDRH+DL8NDrMBBij+U7B1KzVc tUKup71y2MZrwf4aPeidHhMZLcMez0l/nVxYj9nP5ayeYVgyayNr/K0pynsyurhaTUw= X-Gm-Gg: ASbGncs5OD9Q9+TL1+hl8yb93a3rpsc+5pP33mN7qedghiTBp8ZKKJU7QiL2Q637EA3 7lw8iq+GgID/o6k5oSiUqfbbIHuPk1cE4Ae6J2NrsekgdMwSqGrp81kkFaSDUZ3z6pKOs/XJI2f WoUcPg5JoOOu4bs2QOjw+eTPhay6bgdHdkxaOZOP1HX2T4Byru66IUJ9zNi93wwGJQtRCGNrv8F qmhoenQRrkRpfPgx9b3jSP73hdHTThCCLjsPKgsWTt3bm38SghfbxuQZb++sXp/BGMuEXJhdMKs mDY/8UeOXZQydPuqBXg+ryJYfsWJdx5KaagFul5Z3KXXeZVHlx4dTgti3bXJXVwGHg3THZYLrPF Q2rBwYTK17Lh3CufcoGTauoHY0ty/Gvs+tcG++uLIPSVzum3+14WGxhjRk+Oqp0uvUm3R/DVOhL b+h12icpfNhyv9GC4v6w== X-Google-Smtp-Source: AGHT+IE7RaIyMAJaTvPyOiXN+JJtZea0493IhCnfctYazgeVBHja7BYLWwucFVnhI9ICXngYTmNZug== X-Received: by 2002:a05:6830:6182:b0:746:d65b:a3b0 with SMTP id 46e09a7af769-76318d69ba4mr2431458a34.2.1758152063547; Wed, 17 Sep 2025 16:34:23 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:55b7:b662:4c5b:a28e? ([2600:8803:e7e4:1d00:55b7:b662:4c5b:a28e]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-625dbab5cf1sm247661eaf.22.2025.09.17.16.34.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 16:34:23 -0700 (PDT) Message-ID: <0bc1b77c-bbbc-4e8a-a792-fb7e30a2a789@baylibre.com> Date: Wed, 17 Sep 2025 18:34:22 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: temperature: add support for EMC1812 To: Marius Cristea , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250917-iio-emc1812-v1-0-0b1f74cea7ab@microchip.com> <20250917-iio-emc1812-v1-1-0b1f74cea7ab@microchip.com> Content-Language: en-US From: David Lechner In-Reply-To: <20250917-iio-emc1812-v1-1-0b1f74cea7ab@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/17/25 7:21 AM, Marius Cristea wrote: > This is the devicetree schema for Microchip EMC1812/13/14/15/33 > Multichannel Low-Voltage Remote Diode Sensor Family. > > Signed-off-by: Marius Cristea > --- > .../iio/temperature/microchip,emc1812.yaml | 223 +++++++++++++++++++++ > MAINTAINERS | 6 + > 2 files changed, 229 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/temperature/microchip,emc1812.yaml b/Documentation/devicetree/bindings/iio/temperature/microchip,emc1812.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..898d6d246746e229cb004f447872ee6bd5a65074 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/temperature/microchip,emc1812.yaml > @@ -0,0 +1,223 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/temperature/microchip,emc1812.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip EMC1812/13/14/15/33 multichannel temperature sensor > + > +maintainers: > + - Marius Cristea > + > +description: | > + The Microchip EMC1812/13/14/15/33 is a high-accuracy 2-wire multichannel > + low-voltage remote diode temperature monitor. > + > + The datasheet can be found here: > + https://ww1.microchip.com/downloads/aemDocuments/documents/MSLD/ProductDocuments/DataSheets/EMC1812-3-4-5-33-Data-Sheet-DS20005751.pdf The pinouts of these chips look nearly identical to MCP998X. Would it make sense to share a single bindings document for these? Or maybe there would be too many if: blocks and keeping it separate is fine. https://lore.kernel.org/linux-iio/20250829143447.18893-2-victor.duicu@microchip.com/ > + > +properties: > + compatible: > + enum: > + - microchip,emc1812 > + - microchip,emc1813 > + - microchip,emc1814 > + - microchip,emc1815 > + - microchip,emc1833 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 2 > + > + interrupt-names: > + description: > + -alert-therm2 asserts when a diode temperature exceeds the ALERT > + threshold. > + -therm-addr asserts low when the hardware-set THERM limit threshold is > + exceeded by one of the temperature sensors. > + items: > + - const: alert-therm2 > + - const: therm-addr > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + microchip,beta1: > + description: > + Set beta compensation value for external channel 1. > + <0> 0.050 > + <1> 0.066 > + <2> 0.087 > + <3> 0.114 > + <4> 0.150 > + <5> 0.197 > + <6> 0.260 > + <7> 0.342 > + <8> 0.449 > + <9> 0.591 > + <10> 0.778 > + <11> 1.024 > + <12> 1.348 > + <13> 1.773 > + <14> 2.333 > + <15> Diode_Mode > + <16> Auto > + - Diode_Mode is used when measuring a discrete thermal diode > + or a CPU diode that functions like a discrete thermal diode. > + - Auto enables beta auto-detection. The chip monitors > + external diode/transistor and determines the optimum > + setting. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 16 > + default: 16 > + > + microchip,beta2: > + description: > + Set beta compensation value for external channel 2. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 16 > + default: 16 This beta value sounds like something that might not belong in the devicetree. The datasheet says that auto is always the best. So that makes me wonder when would we want to use something else? Also, it says that in auto mode, that the value is recalculated on every conversion, so even if manually selecting a value, it sounds like something that could change at runtime, so having a fixed value might not cover all use cases. Having a boolean flag to say this is wired to a discrete thermal diode makes sense though (the driver would use this info to select diode mode). And if we can make the case that the beta value should be in the devicetree, then having the actual value instead of a lookup table would be preferred. There is a "basis points" standards unit (suffix "-bp") that can be used for non-integer values like this (assuming it is a unit-less value). It is 1/10,000 so it would make the property an enum with 15 values between 500 and 23330. Both properties would not be allowed at the same time and if both properties are omitted, the driver would know to use auto mode. Also, it would make more sense to have these as channel properties if they only apply to 1 channel each. > + > + microchip,parasitic-res-on-channel1-2: > + description: > + Indicates that the chip and the diodes/transistors are sufficiently far > + apart that a parasitic resistance is added to the wires, which can affect > + the measurements. Due to the anti-parallel diode connections, channels > + 1 and 2 are affected together. > + type: boolean > + > + microchip,parasitic-res-on-channel3-4: > + description: > + Indicates that the chip and the diodes/transistors are sufficiently far > + apart that a parasitic resistance is added to the wires, which can affect > + the measurements. Due to the anti-parallel diode connections, channels > + 3 and 4 are affected together. > + type: boolean > + > + vdd-supply: true > + > +patternProperties: > + "^channel@[1-4]$": > + description: > + Represents the external temperature channels to which > + a remote diode is connected. > + type: object > + > + properties: > + reg: > + items: > + minimum: 1 > + maximum: 4 > + I.e. beta-related properties would go here. > + microchip,ideality-factor: > + description: > + Each channel has an ideality factor. > + Beta compensation and resistance error correction automatically > + correct for most ideality errors. So ideality factor does not need > + to be adjusted in general. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 8 > + maximum: 55 > + default: 18 > +