From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene@kernel.org Subject: RE: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX. Date: Fri, 13 Dec 2013 18:24:59 +0900 Message-ID: <0bc301cef7e5$319ac0c0$94d04240$@kernel.org> References: <1378889173-7437-1-git-send-email-jose.goncalves@inov.pt> <52AA6909.8050200@inov.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <52AA6909.8050200@inov.pt> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: =?ISO-8859-1?Q?'Jos=E9_Miguel_Gon=E7alves'?= , 'Linus Walleij' , 'Tomasz Figa' Cc: 'linux-samsung-soc' , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?'Heiko_St=FCbner'?= List-Id: linux-gpio@vger.kernel.org Jos=E9 Miguel Gon=E7alves wrote: >=20 > On 27-09-2013 15:17, Linus Walleij wrote: > > On Wed, Sep 11, 2013 at 10:46 AM, Jos=E9 Miguel Gon=E7alves > > wrote: > > > >> Some GPIO line limits are incorrectly set which, for instance, > >> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip. > >> > >> Signed-off-by: Jos=E9 Miguel Gon=E7alves > >> --- > >> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++----- > > OK but grrrr! > > > > What needs to happen to the s3c24xx is to get rid of this file. > > > > - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry > > ARCH_NR_GPIO like everyone else > > > > - Get rid of the config symbol NEED_MACH_GPIO_H > > > > - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h > > or whatever and make it local... > > > > I will try to do this myself if noone else helps out, so I'd like t= o > > carry this patch in the GPIO tree provided I can get an ACK from > > the S3C24xx maintainer. Tomasz, is that you or Kukjin? > > > > (BTW the above maybe goes for S3c64xx as well .. and S5P > > oh well I will get to it.) > > >=20 > Was this patch forgotten? >=20 Hi Jose, Sorry about missing your patch. It's my fault :( and as you know, at th= is moment the file will be removed by Linus' patch... Anyway, let me look at the Samsung patches closely ;) Thanks, Kukjin