From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
David Wei <dw@davidwei.uk>,
io-uring@vger.kernel.org
Subject: Re: [PATCH v1 1/4] io_uring: only account cqring wait time as iowait if enabled for a ring
Date: Sun, 25 Feb 2024 14:33:35 -0700 [thread overview]
Message-ID: <0be7ea7a-12e5-4967-beea-279fa98f87cf@kernel.dk> (raw)
In-Reply-To: <a19fc5fb-cbb3-4a61-bce2-d6cb52227c19@kernel.dk>
On 2/25/24 2:11 PM, Jens Axboe wrote:
> On 2/25/24 9:43 AM, Jens Axboe wrote:
>> If you are motivated, please dig into it. If not, I guess I will take a
>> look this week.
>
> The straight forward approach - add a nr_short_wait and ->in_short_wait
> and ensure that the idle governor factors that in. Not sure how
> palatable it is, would be nice fold iowait under this, but doesn't
> really work with how we pass back the previous state.
Split into 3 separate patches here. No changes from the previous email.
Tested it, and it works.
https://git.kernel.dk/cgit/linux/log/?h=iowait
--
Jens Axboe
next prev parent reply other threads:[~2024-02-25 21:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 5:07 [PATCH v1 1/4] io_uring: only account cqring wait time as iowait if enabled for a ring David Wei
2024-02-24 5:07 ` [PATCH v1 2/4] liburing: add examples/proxy to .gitignore David Wei
2024-02-24 5:07 ` [PATCH v1 3/4] liburing: add helper for IORING_REGISTER_IOWAIT David Wei
2024-02-24 15:29 ` Jens Axboe
2024-02-24 16:39 ` David Wei
2024-02-24 5:07 ` [PATCH v1 4/4] liburing: add unit test for io_uring_register_iowait() David Wei
2024-02-24 15:28 ` [PATCH v1 1/4] io_uring: only account cqring wait time as iowait if enabled for a ring Jens Axboe
2024-02-24 15:31 ` Pavel Begunkov
2024-02-24 17:20 ` David Wei
2024-02-24 18:55 ` Jens Axboe
2024-02-25 1:39 ` Pavel Begunkov
2024-02-25 16:43 ` Jens Axboe
2024-02-25 21:11 ` Jens Axboe
2024-02-25 21:33 ` Jens Axboe [this message]
2024-02-26 14:56 ` Pavel Begunkov
2024-02-26 15:22 ` Jens Axboe
2024-02-24 18:51 ` Jens Axboe
2024-02-25 0:58 ` Pavel Begunkov
2024-02-25 16:39 ` Jens Axboe
2024-03-05 14:59 ` Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0be7ea7a-12e5-4967-beea-279fa98f87cf@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.