From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97134A2F for ; Thu, 21 Mar 2024 23:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711063824; cv=none; b=GzAaEljbX/wXEgV653EJkozosz+otW/NNFWjxDiA9H8pwdcuUI3nkxzOzQIJe94MQkV4yoIeiE1NF37UPQu6w2zgev1KBrX832/OIr7X3htXHVkcu6MghQg3eS0OqhLkmyaIRT9AwNBttWFePb6JM+A0wwgySVAADhYm4B/ZCdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711063824; c=relaxed/simple; bh=+iwbmtAJP90jjSvoeQzy7BhGDR7QGKSXSv//kR6Y4Ok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BE0PqiYEhHNqxTeWQJ+gE4/uf06isqqQiz9ygAY5dzA5WY6ZLKrRP25z2lMpwCxlMS6rsf8Nk/oPsWS2LrziCbGhEgvYB80qD4oOqu7Q4y81S0XV03T/vI8bIMXsuVNNX3fFDHqiPD2jvP8ATwM4KIG6t0Yuv45T1cSnoJZnKSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MZNSEQs5; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MZNSEQs5" Message-ID: <0be8711f-31cb-4bfa-8501-4ad11e34b09a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711063819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JUKRlKfRws+/FxXAEZkSJcbbjD61bO3gnsZWEBPgNek=; b=MZNSEQs5otXzS0VjwkryDeKsKBQQ9QbgQN+uBW+PB5poxTPY396E4EAYBaI8N63JGrC43Z zncO/c6ofwcBjM6bXLlpx+v+4Q/KBPGdxpSMEEUI/SALRwjbn+EqS3SJglHdM0DEHWAPGn WwNZJlsyGGyc0BGqpktbEgkpemfG7Dk= Date: Thu, 21 Mar 2024 16:30:11 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2] bpf: fix warning for crash_kexec Content-Language: en-GB To: Andrii Nakryiko , Hari Bathini Cc: bpf@vger.kernel.org, Daniel Borkmann , Andrii Nakryiko , Alexei Starovoitov , Kexec-ml , Baoquan He , Andrew Morton , Jiri Olsa , Stanislav Fomichev References: <20240319080152.36987-1-hbathini@linux.ibm.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 3/19/24 3:56 PM, Andrii Nakryiko wrote: > On Tue, Mar 19, 2024 at 1:02 AM Hari Bathini wrote: >> With [1], crash dump specific code is moved out of CONFIG_KEXEC_CORE >> and placed under CONFIG_CRASH_DUMP, where it is more appropriate. >> And since CONFIG_KEXEC & !CONFIG_CRASH_DUMP build option is supported >> with that, it led to the below warning: >> >> "WARN: resolve_btfids: unresolved symbol crash_kexec" >> >> Fix it by using the appropriate #ifdef. >> >> [1] https://lore.kernel.org/all/20240124051254.67105-1-bhe@redhat.com/ >> >> Acked-by: Baoquan He >> Fixes: 29fd9ae62910 ("crash: split crash dumping code out from kexec_core.c") > I don't think either bpf or bpf-next have this commit just yet, so > landing it in the bpf/bpf-next tree doesn't make much sense. It > probably would be best to land it through the tree which does the > CONFIG_KEXEC_CORE -> CONFIG_CRASH_DUMP change in kernel/Makefile. With bpf-next, I found the config at kernel/Kconfig.kexec: config CRASH_DUMP         bool "kernel crash dumps"         depends on ARCH_SUPPORTS_CRASH_DUMP         select CRASH_CORE         select KEXEC_CORE         help ... > pw-bot: cr > >> Acked-by: Jiri Olsa >> Acked-by: Stanislav Fomichev >> Signed-off-by: Hari Bathini >> --- >> >> Changes in v2: >> * Updated changelog. >> * Added Fixes and Acked-by tags. >> >> >> kernel/bpf/helpers.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c >> index a89587859571..449b9a5d3fe3 100644 >> --- a/kernel/bpf/helpers.c >> +++ b/kernel/bpf/helpers.c >> @@ -2548,7 +2548,7 @@ __bpf_kfunc void bpf_throw(u64 cookie) >> __bpf_kfunc_end_defs(); >> >> BTF_KFUNCS_START(generic_btf_ids) >> -#ifdef CONFIG_KEXEC_CORE >> +#ifdef CONFIG_CRASH_DUMP >> BTF_ID_FLAGS(func, crash_kexec, KF_DESTRUCTIVE) >> #endif >> BTF_ID_FLAGS(func, bpf_obj_new_impl, KF_ACQUIRE | KF_RET_NULL) >> -- >> 2.44.0 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B38DC54E58 for ; Thu, 21 Mar 2024 23:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wf3KIg6QT0+1sbIfdY6qB7YTYhhh33GJ5+9pQP+uZIU=; b=ZyiJpVL7PgmDE4 3REvHMY2wWslRxWoxMD7tclzSkt+ZJDkSEPx8UFNhM3FN93hl3oCfn7oNFlyT9Ik6CU3P6vD2G79K JVsqjOLMYHLOdKGCgAQ1os7lYrBsFClVQ8zXrLgIxiTUNEVtNFfNMqVcDpqr0Gbals9lPTHhtDKgE SEEEfs4EJtl2K2kN2fmoI5DA61Pwk29mSxeWTmOfrjjka7kCVTJeMAaN5hIYD8jH4G6BWBiPmvDsX NS7zLDQ3JLGyZttoKsj+jbSk2Ghzd5l/Q62nWFjeZOoGJuWwV4uTWHCA1ZQYQf7jFS9Eqcj9wgRXX dXwCX8TCHgHLZBawswHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnRrk-000000056eR-0MGR; Thu, 21 Mar 2024 23:30:32 +0000 Received: from out-171.mta0.migadu.com ([2001:41d0:1004:224b::ab]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnRrf-000000056cE-2tNk for kexec@lists.infradead.org; Thu, 21 Mar 2024 23:30:31 +0000 Message-ID: <0be8711f-31cb-4bfa-8501-4ad11e34b09a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711063819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JUKRlKfRws+/FxXAEZkSJcbbjD61bO3gnsZWEBPgNek=; b=MZNSEQs5otXzS0VjwkryDeKsKBQQ9QbgQN+uBW+PB5poxTPY396E4EAYBaI8N63JGrC43Z zncO/c6ofwcBjM6bXLlpx+v+4Q/KBPGdxpSMEEUI/SALRwjbn+EqS3SJglHdM0DEHWAPGn WwNZJlsyGGyc0BGqpktbEgkpemfG7Dk= Date: Thu, 21 Mar 2024 16:30:11 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2] bpf: fix warning for crash_kexec Content-Language: en-GB To: Andrii Nakryiko , Hari Bathini Cc: bpf@vger.kernel.org, Daniel Borkmann , Andrii Nakryiko , Alexei Starovoitov , Kexec-ml , Baoquan He , Andrew Morton , Jiri Olsa , Stanislav Fomichev References: <20240319080152.36987-1-hbathini@linux.ibm.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240321_163029_507280_798AD8F0 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org Ck9uIDMvMTkvMjQgMzo1NiBQTSwgQW5kcmlpIE5ha3J5aWtvIHdyb3RlOgo+IE9uIFR1ZSwgTWFy IDE5LCAyMDI0IGF0IDE6MDLigK9BTSBIYXJpIEJhdGhpbmkgPGhiYXRoaW5pQGxpbnV4LmlibS5j b20+IHdyb3RlOgo+PiBXaXRoIFsxXSwgY3Jhc2ggZHVtcCBzcGVjaWZpYyBjb2RlIGlzIG1vdmVk IG91dCBvZiBDT05GSUdfS0VYRUNfQ09SRQo+PiBhbmQgcGxhY2VkIHVuZGVyIENPTkZJR19DUkFT SF9EVU1QLCB3aGVyZSBpdCBpcyBtb3JlIGFwcHJvcHJpYXRlLgo+PiBBbmQgc2luY2UgQ09ORklH X0tFWEVDICYgIUNPTkZJR19DUkFTSF9EVU1QIGJ1aWxkIG9wdGlvbiBpcyBzdXBwb3J0ZWQKPj4g d2l0aCB0aGF0LCBpdCBsZWQgdG8gdGhlIGJlbG93IHdhcm5pbmc6Cj4+Cj4+ICAgICJXQVJOOiBy ZXNvbHZlX2J0ZmlkczogdW5yZXNvbHZlZCBzeW1ib2wgY3Jhc2hfa2V4ZWMiCj4+Cj4+IEZpeCBp dCBieSB1c2luZyB0aGUgYXBwcm9wcmlhdGUgI2lmZGVmLgo+Pgo+PiBbMV0gaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvYWxsLzIwMjQwMTI0MDUxMjU0LjY3MTA1LTEtYmhlQHJlZGhhdC5jb20vCj4+ Cj4+IEFja2VkLWJ5OiBCYW9xdWFuIEhlIDxiaGVAcmVkaGF0LmNvbT4KPj4gRml4ZXM6IDI5ZmQ5 YWU2MjkxMCAoImNyYXNoOiBzcGxpdCBjcmFzaCBkdW1waW5nIGNvZGUgb3V0IGZyb20ga2V4ZWNf Y29yZS5jIikKPiBJIGRvbid0IHRoaW5rIGVpdGhlciBicGYgb3IgYnBmLW5leHQgaGF2ZSB0aGlz IGNvbW1pdCBqdXN0IHlldCwgc28KPiBsYW5kaW5nIGl0IGluIHRoZSBicGYvYnBmLW5leHQgdHJl ZSBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZS4gSXQKPiBwcm9iYWJseSB3b3VsZCBiZSBiZXN0IHRv IGxhbmQgaXQgdGhyb3VnaCB0aGUgdHJlZSB3aGljaCBkb2VzIHRoZQo+IENPTkZJR19LRVhFQ19D T1JFIC0+IENPTkZJR19DUkFTSF9EVU1QIGNoYW5nZSBpbiBrZXJuZWwvTWFrZWZpbGUuCgpXaXRo IGJwZi1uZXh0LCBJIGZvdW5kIHRoZSBjb25maWcgYXQga2VybmVsL0tjb25maWcua2V4ZWM6Cgpj b25maWcgQ1JBU0hfRFVNUAogwqDCoMKgwqDCoMKgwqAgYm9vbCAia2VybmVsIGNyYXNoIGR1bXBz IgogwqDCoMKgwqDCoMKgwqAgZGVwZW5kcyBvbiBBUkNIX1NVUFBPUlRTX0NSQVNIX0RVTVAKIMKg wqDCoMKgwqDCoMKgIHNlbGVjdCBDUkFTSF9DT1JFCiDCoMKgwqDCoMKgwqDCoCBzZWxlY3QgS0VY RUNfQ09SRQogwqDCoMKgwqDCoMKgwqAgaGVscAoKLi4uCgo+IHB3LWJvdDogY3IKPgo+PiBBY2tl ZC1ieTogSmlyaSBPbHNhIDxqb2xzYUBrZXJuZWwub3JnPgo+PiBBY2tlZC1ieTogU3RhbmlzbGF2 IEZvbWljaGV2IDxzZGZAZ29vZ2xlLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogSGFyaSBCYXRoaW5p IDxoYmF0aGluaUBsaW51eC5pYm0uY29tPgo+PiAtLS0KPj4KPj4gQ2hhbmdlcyBpbiB2MjoKPj4g KiBVcGRhdGVkIGNoYW5nZWxvZy4KPj4gKiBBZGRlZCBGaXhlcyBhbmQgQWNrZWQtYnkgdGFncy4K Pj4KPj4KPj4gICBrZXJuZWwvYnBmL2hlbHBlcnMuYyB8IDIgKy0KPj4gICAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2tlcm5l bC9icGYvaGVscGVycy5jIGIva2VybmVsL2JwZi9oZWxwZXJzLmMKPj4gaW5kZXggYTg5NTg3ODU5 NTcxLi40NDliOWE1ZDNmZTMgMTAwNjQ0Cj4+IC0tLSBhL2tlcm5lbC9icGYvaGVscGVycy5jCj4+ ICsrKyBiL2tlcm5lbC9icGYvaGVscGVycy5jCj4+IEBAIC0yNTQ4LDcgKzI1NDgsNyBAQCBfX2Jw Zl9rZnVuYyB2b2lkIGJwZl90aHJvdyh1NjQgY29va2llKQo+PiAgIF9fYnBmX2tmdW5jX2VuZF9k ZWZzKCk7Cj4+Cj4+ICAgQlRGX0tGVU5DU19TVEFSVChnZW5lcmljX2J0Zl9pZHMpCj4+IC0jaWZk ZWYgQ09ORklHX0tFWEVDX0NPUkUKPj4gKyNpZmRlZiBDT05GSUdfQ1JBU0hfRFVNUAo+PiAgIEJU Rl9JRF9GTEFHUyhmdW5jLCBjcmFzaF9rZXhlYywgS0ZfREVTVFJVQ1RJVkUpCj4+ICAgI2VuZGlm Cj4+ICAgQlRGX0lEX0ZMQUdTKGZ1bmMsIGJwZl9vYmpfbmV3X2ltcGwsIEtGX0FDUVVJUkUgfCBL Rl9SRVRfTlVMTCkKPj4gLS0KPj4gMi40NC4wCj4+CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tl eGVjCg==