From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B363C433ED for ; Tue, 18 May 2021 15:11:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DD3861042 for ; Tue, 18 May 2021 15:11:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DD3861042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D9C86EB9F; Tue, 18 May 2021 15:11:47 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33F776EB9F for ; Tue, 18 May 2021 15:11:46 +0000 (UTC) IronPort-SDR: nmjPLHHUwb94IKUQqykaHqHu6vYR3EbABVa9R9uUz2Dv9s8uKNKWvKJqBSe+6Ug9Vwl+inYT1a fI87JZHQfQOg== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="261964791" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="261964791" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 08:11:45 -0700 IronPort-SDR: lYe57+1s7TuhOtb38mWVshyUt/ytu5K2wuiwsKa9BdUMB274kVBw5aIP/WW0we9Wcp0POFYV7C oBKWY/Fwfsag== X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="439079824" Received: from cmutgix-mobl.gar.corp.intel.com (HELO [10.249.254.195]) ([10.249.254.195]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 08:11:44 -0700 Subject: Re: [PATCH v2 13/15] drm/ttm: Add BO and offset arguments for vm_access and vm_fault ttm handlers. To: =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20210518145543.1042429-1-thomas.hellstrom@linux.intel.com> <9e465ab2-4272-4a41-2ebf-4b34d4724f77@amd.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= Message-ID: <0beb46d3-96c8-dcfd-6540-e23ff7207888@linux.intel.com> Date: Tue, 18 May 2021 17:11:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <9e465ab2-4272-4a41-2ebf-4b34d4724f77@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/18/21 5:07 PM, Christian König wrote: > Am 18.05.21 um 16:55 schrieb Thomas Hellström: >> From: Maarten Lankhorst >> >> This allows other drivers that may not setup the vma in the same way >> to use the ttm bo helpers. > > Uff can you please explain why exactly you need that? > > Providing the BO is not much of a problem, but having the BO at > different VMA offsets is really a no-go with TTM. > > Christian. The current i915 uapi is using different offsets for different caching :/. We're currently working around that by using ttm_bo_type_kernel (no TTM vma offset at all) and i915's offset. /Thomas