From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB539C001DB for ; Fri, 4 Aug 2023 10:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RDxSOVfmsfEJrchqRw2mB4bGDRkmgv5L+s4JPKXzDSM=; b=mcGfYUB9zD9P8F MkJ6faV1/jbSWIJpWBtdNfXHCh7n1BfrtK3MgFZZkzGmTNG6bS8lf5iGhszHVq7ZevWhTqyIfCuwk ct2hL6Q6ly1weyGAleqNSITatVwk+utND0XXN/Q7s6eaTYrA8Z3RIR4lvqaImeXeogq5sfDqUMjR2 yC9Oyen2kT+bxk1nqkdqy6w+PXJFXfLwG5rSspJkEpCcDT8plLuHcyTPnSRpKNJQr5g5C0wpndjvf XFN4E/NUyHVUIJd5N3NSKmU+L9z2cLv/X+Gx02vPjX8PM38jK0A1G0QoEpW/auf5ItDPK7CI2vAdO qE3hLjWUMvH1wMEMyq+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRrcn-00C56Y-1E; Fri, 04 Aug 2023 10:01:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRrck-00C56A-1E for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 10:01:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DA2C1007; Fri, 4 Aug 2023 03:02:14 -0700 (PDT) Received: from [10.163.54.21] (unknown [10.163.54.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 926CF3F6C4; Fri, 4 Aug 2023 03:01:27 -0700 (PDT) Message-ID: <0c26e6cc-d75a-e89f-4ecc-54170df2ed47@arm.com> Date: Fri, 4 Aug 2023 15:31:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 2/4] arm_pmu: acpi: Add a representative platform device for TRBE Content-Language: en-US To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Sami Mujawar , Catalin Marinas , Will Deacon , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230803055652.1322801-1-anshuman.khandual@arm.com> <20230803055652.1322801-3-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: <20230803055652.1322801-3-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_030134_537772_AF87EB40 X-CRM114-Status: GOOD ( 26.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/3/23 11:26, Anshuman Khandual wrote: > ACPI TRBE does not have a HID for identification which could create and add > a platform device into the platform bus. Also without a platform device, it > cannot be probed and bound to a platform driver. > > This creates a dummy platform device for TRBE after ascertaining that ACPI > provides required interrupts uniformly across all cpus on the system. This > device gets created inside drivers/perf/arm_pmu_acpi.c to accommodate TRBE > being built as a module. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/acpi.h | 3 +++ > drivers/perf/arm_pmu_acpi.c | 37 ++++++++++++++++++++++++++++++++++- > include/linux/perf/arm_pmu.h | 1 + > 3 files changed, 40 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index bd68e1b7f29f..4d537d56eb84 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -42,6 +42,9 @@ > #define ACPI_MADT_GICC_SPE (offsetof(struct acpi_madt_generic_interrupt, \ > spe_interrupt) + sizeof(u16)) > > +#define ACPI_MADT_GICC_TRBE (offsetof(struct acpi_madt_generic_interrupt, \ > + trbe_interrupt) + sizeof(u16)) > + > /* Basic configuration for ACPI */ > #ifdef CONFIG_ACPI > pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > index 235c14766a36..79feea548e6e 100644 > --- a/drivers/perf/arm_pmu_acpi.c > +++ b/drivers/perf/arm_pmu_acpi.c > @@ -69,7 +69,7 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > acpi_unregister_gsi(gsi); > } > > -#if IS_ENABLED(CONFIG_ARM_SPE_PMU) > +#if IS_ENABLED(CONFIG_ARM_SPE_PMU) || IS_ENABLED(CONFIG_CORESIGHT_TRBE) Rather than adding IS_ENABLED() checks for all applicable configs in future which will need to call arm_acpi_register_pmu_device() for a dummy platform device, could we instead just add __maybe_unused for the function to prevent build warning when there are no call sites ? Seems bit better and simpler. > static int > arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, > u16 (*parse_gsi)(struct acpi_madt_generic_interrupt *)) > @@ -166,6 +166,40 @@ static inline void arm_spe_acpi_register_device(void) > } > #endif /* CONFIG_ARM_SPE_PMU */ > > +#ifdef CONFIG_CORESIGHT_TRBE > +static struct resource trbe_resources[] = { > + { > + /* irq */ > + .flags = IORESOURCE_IRQ, > + } > +}; > + > +static struct platform_device trbe_dev = { > + .name = ARMV8_TRBE_PDEV_NAME, > + .id = -1, > + .resource = trbe_resources, > + .num_resources = ARRAY_SIZE(trbe_resources) > +}; > + > +static u16 arm_trbe_parse_gsi(struct acpi_madt_generic_interrupt *gicc) > +{ > + return gicc->trbe_interrupt; > +} > + > +static void arm_trbe_acpi_register_device(void) > +{ > + int ret = arm_acpi_register_pmu_device(&trbe_dev, ACPI_MADT_GICC_TRBE, > + arm_trbe_parse_gsi); > + if (ret) > + pr_warn("ACPI: TRBE: Unable to register device\n"); > +} > +#else > +static inline void arm_trbe_acpi_register_device(void) > +{ > + > +} > +#endif /* CONFIG_CORESIGHT_TRBE */ > + > static int arm_pmu_acpi_parse_irqs(void) > { > int irq, cpu, irq_cpu, err; > @@ -401,6 +435,7 @@ static int arm_pmu_acpi_init(void) > return 0; > > arm_spe_acpi_register_device(); > + arm_trbe_acpi_register_device(); > > return 0; > } > diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h > index a0801f68762b..143fbc10ecfe 100644 > --- a/include/linux/perf/arm_pmu.h > +++ b/include/linux/perf/arm_pmu.h > @@ -187,5 +187,6 @@ void armpmu_free_irq(int irq, int cpu); > #endif /* CONFIG_ARM_PMU */ > > #define ARMV8_SPE_PDEV_NAME "arm,spe-v1" > +#define ARMV8_TRBE_PDEV_NAME "arm,trbe" > > #endif /* __ARM_PMU_H__ */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1B9C001DB for ; Fri, 4 Aug 2023 10:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbjHDKCL (ORCPT ); Fri, 4 Aug 2023 06:02:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbjHDKBo (ORCPT ); Fri, 4 Aug 2023 06:01:44 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D2FD4EC7 for ; Fri, 4 Aug 2023 03:01:32 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DA2C1007; Fri, 4 Aug 2023 03:02:14 -0700 (PDT) Received: from [10.163.54.21] (unknown [10.163.54.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 926CF3F6C4; Fri, 4 Aug 2023 03:01:27 -0700 (PDT) Message-ID: <0c26e6cc-d75a-e89f-4ecc-54170df2ed47@arm.com> Date: Fri, 4 Aug 2023 15:31:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 2/4] arm_pmu: acpi: Add a representative platform device for TRBE Content-Language: en-US To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Sami Mujawar , Catalin Marinas , Will Deacon , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230803055652.1322801-1-anshuman.khandual@arm.com> <20230803055652.1322801-3-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: <20230803055652.1322801-3-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/3/23 11:26, Anshuman Khandual wrote: > ACPI TRBE does not have a HID for identification which could create and add > a platform device into the platform bus. Also without a platform device, it > cannot be probed and bound to a platform driver. > > This creates a dummy platform device for TRBE after ascertaining that ACPI > provides required interrupts uniformly across all cpus on the system. This > device gets created inside drivers/perf/arm_pmu_acpi.c to accommodate TRBE > being built as a module. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/acpi.h | 3 +++ > drivers/perf/arm_pmu_acpi.c | 37 ++++++++++++++++++++++++++++++++++- > include/linux/perf/arm_pmu.h | 1 + > 3 files changed, 40 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index bd68e1b7f29f..4d537d56eb84 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -42,6 +42,9 @@ > #define ACPI_MADT_GICC_SPE (offsetof(struct acpi_madt_generic_interrupt, \ > spe_interrupt) + sizeof(u16)) > > +#define ACPI_MADT_GICC_TRBE (offsetof(struct acpi_madt_generic_interrupt, \ > + trbe_interrupt) + sizeof(u16)) > + > /* Basic configuration for ACPI */ > #ifdef CONFIG_ACPI > pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > index 235c14766a36..79feea548e6e 100644 > --- a/drivers/perf/arm_pmu_acpi.c > +++ b/drivers/perf/arm_pmu_acpi.c > @@ -69,7 +69,7 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > acpi_unregister_gsi(gsi); > } > > -#if IS_ENABLED(CONFIG_ARM_SPE_PMU) > +#if IS_ENABLED(CONFIG_ARM_SPE_PMU) || IS_ENABLED(CONFIG_CORESIGHT_TRBE) Rather than adding IS_ENABLED() checks for all applicable configs in future which will need to call arm_acpi_register_pmu_device() for a dummy platform device, could we instead just add __maybe_unused for the function to prevent build warning when there are no call sites ? Seems bit better and simpler. > static int > arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, > u16 (*parse_gsi)(struct acpi_madt_generic_interrupt *)) > @@ -166,6 +166,40 @@ static inline void arm_spe_acpi_register_device(void) > } > #endif /* CONFIG_ARM_SPE_PMU */ > > +#ifdef CONFIG_CORESIGHT_TRBE > +static struct resource trbe_resources[] = { > + { > + /* irq */ > + .flags = IORESOURCE_IRQ, > + } > +}; > + > +static struct platform_device trbe_dev = { > + .name = ARMV8_TRBE_PDEV_NAME, > + .id = -1, > + .resource = trbe_resources, > + .num_resources = ARRAY_SIZE(trbe_resources) > +}; > + > +static u16 arm_trbe_parse_gsi(struct acpi_madt_generic_interrupt *gicc) > +{ > + return gicc->trbe_interrupt; > +} > + > +static void arm_trbe_acpi_register_device(void) > +{ > + int ret = arm_acpi_register_pmu_device(&trbe_dev, ACPI_MADT_GICC_TRBE, > + arm_trbe_parse_gsi); > + if (ret) > + pr_warn("ACPI: TRBE: Unable to register device\n"); > +} > +#else > +static inline void arm_trbe_acpi_register_device(void) > +{ > + > +} > +#endif /* CONFIG_CORESIGHT_TRBE */ > + > static int arm_pmu_acpi_parse_irqs(void) > { > int irq, cpu, irq_cpu, err; > @@ -401,6 +435,7 @@ static int arm_pmu_acpi_init(void) > return 0; > > arm_spe_acpi_register_device(); > + arm_trbe_acpi_register_device(); > > return 0; > } > diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h > index a0801f68762b..143fbc10ecfe 100644 > --- a/include/linux/perf/arm_pmu.h > +++ b/include/linux/perf/arm_pmu.h > @@ -187,5 +187,6 @@ void armpmu_free_irq(int irq, int cpu); > #endif /* CONFIG_ARM_PMU */ > > #define ARMV8_SPE_PDEV_NAME "arm,spe-v1" > +#define ARMV8_TRBE_PDEV_NAME "arm,trbe" > > #endif /* __ARM_PMU_H__ */