From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH] i2c: davinci: Avoid zero value of CLKH Date: Fri, 20 Jul 2018 13:43:46 -0500 Message-ID: <0c29ccf5-4077-47a2-e7e0-c89ffcf8cb0b@ti.com> References: <20180713152017.2207-1-alexander.sverdlin@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sekhar Nori , Alexander Sverdlin , linux-i2c@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Kevin Hilman List-Id: linux-i2c@vger.kernel.org On 07/17/2018 06:57 AM, Sekhar Nori wrote: > On Friday 13 July 2018 08:50 PM, Alexander Sverdlin wrote: >> If CLKH is set to 0 I2C clock is not generated at all, so avoid this value >> and stretch the clock in this case. > > This must be by observation since specification does not seem to state > this. It will be good to know (mention) on what hw was it observed? > >> >> Signed-off-by: Alexander Sverdlin > > In any case, the patch is fine. > > Acked-by: Sekhar Nori > [...] -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Fri, 20 Jul 2018 13:43:46 -0500 Subject: [PATCH] i2c: davinci: Avoid zero value of CLKH In-Reply-To: References: <20180713152017.2207-1-alexander.sverdlin@nokia.com> Message-ID: <0c29ccf5-4077-47a2-e7e0-c89ffcf8cb0b@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/17/2018 06:57 AM, Sekhar Nori wrote: > On Friday 13 July 2018 08:50 PM, Alexander Sverdlin wrote: >> If CLKH is set to 0 I2C clock is not generated at all, so avoid this value >> and stretch the clock in this case. > > This must be by observation since specification does not seem to state > this. It will be good to know (mention) on what hw was it observed? > >> >> Signed-off-by: Alexander Sverdlin > > In any case, the patch is fine. > > Acked-by: Sekhar Nori > [...] -- regards, -grygorii