From: Saeed Mahameed <saeed@kernel.org>
To: Eric Dumazet <edumazet@google.com>, Vladimir Oltean <olteanv@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
George McCollister <george.mccollister@gmail.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Arnd Bergmann <arnd@arndb.de>, Taehee Yoo <ap420073@gmail.com>,
Jiri Pirko <jiri@mellanox.com>, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH v3 net-next 10/12] net: bonding: ensure .ndo_get_stats64 can sleep
Date: Fri, 08 Jan 2021 11:38:57 -0800 [thread overview]
Message-ID: <0c2b5e3ee14addfb86f023f2108bacc4e5c5652b.camel@kernel.org> (raw)
In-Reply-To: <CANn89i+1KEyGDm-9RXpK4H6aWtn5Zmo3rgj_+zWYwFXhxm8bvg@mail.gmail.com>
On Fri, 2021-01-08 at 10:27 +0100, Eric Dumazet wrote:
> On Fri, Jan 8, 2021 at 10:21 AM Vladimir Oltean <olteanv@gmail.com>
> wrote:
> > On Fri, Jan 08, 2021 at 10:14:01AM +0100, Eric Dumazet wrote:
> > > If you disagree, repost a rebased patch series so that we can
> > > test/compare and choose the best solution.
> >
> > I would rather use Saeed's time as a reviewer to my existing and
> > current
> > patch set.
>
> Yes, same feeling here, but Saeed brought back his own old
> implementation, so maybe he does not feel the same way ?
Agreed, Vladimir's work is more complete than mine, my work was just a
RFC to show the concept, it was far from being ready or testable with
some use cases such as bonding/bridge/ovs/etc...
Let me take a look at the current series, and if I see that the
rcu/dev_hold approach is more lightweight then i will suggest it to
Vladimir and he can make the final decision.
next prev parent reply other threads:[~2021-01-08 19:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 9:49 [PATCH v3 net-next 00/12] Make .ndo_get_stats64 sleepable Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 01/12] net: mark dev_base_lock for deprecation Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 02/12] net: introduce a mutex for the netns interface lists Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 03/12] net: procfs: hold netif_lists_lock when retrieving device statistics Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 04/12] net: sysfs: don't hold dev_base_lock while " Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 05/12] s390/appldata_net_sum: hold the netdev lists lock when " Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 06/12] parisc/led: reindent the code that gathers " Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 07/12] parisc/led: hold the netdev lists lock when retrieving " Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 08/12] net: make dev_get_stats return void Vladimir Oltean
2021-01-07 13:01 ` kernel test robot
2021-01-07 13:01 ` kernel test robot
2021-01-07 13:15 ` Vladimir Oltean
2021-01-08 0:50 ` Rong Chen
2021-01-08 0:50 ` Rong Chen
2021-01-07 9:49 ` [PATCH v3 net-next 09/12] net: net_failover: ensure .ndo_get_stats64 can sleep Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 10/12] net: bonding: " Vladimir Oltean
2021-01-07 11:18 ` Eric Dumazet
2021-01-07 11:33 ` Vladimir Oltean
2021-01-07 12:58 ` Eric Dumazet
2021-01-08 3:59 ` Saeed Mahameed
2021-01-08 8:57 ` Vladimir Oltean
2021-01-08 19:25 ` Saeed Mahameed
2021-01-08 9:14 ` Eric Dumazet
2021-01-08 9:21 ` Vladimir Oltean
2021-01-08 9:27 ` Eric Dumazet
2021-01-08 19:38 ` Saeed Mahameed [this message]
2021-01-08 20:20 ` Vladimir Oltean
2021-01-08 19:33 ` Saeed Mahameed
2021-01-07 9:49 ` [PATCH v3 net-next 11/12] net: mark ndo_get_stats64 as being able to sleep Vladimir Oltean
2021-01-07 9:49 ` [PATCH v3 net-next 12/12] net: remove obsolete comments about ndo_get_stats64 context from eth drivers Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c2b5e3ee14addfb86f023f2108bacc4e5c5652b.camel@kernel.org \
--to=saeed@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=george.mccollister@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vfalico@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.