Re: [Buildroot] [PATCH v2] configs/cubieboard1: new defconfig

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Hi Gero,

sorry for the late reply,

On 10/08/23 22:48, Gero Schwäricke wrote:
> Support for Cubieboard 1 from Cubietech.

commit log lacks product URL. I'd go with:
"
This patch adds support for Cubietech Cubieboard1.

Cubieboard1 features can be found here:
http://www.cubietech.com/product-detail/cubieboard1/
"

> Signed-off-by: Gero Schwäricke <gero@schwaericke.email>
> ---
> Changes v1 -> v2:
>    - fix commit subject format
>    - add myself to DEVELOPERS
>    - add board/cubieboard1/readme.txt
>    - use extlinux.conf instead of boot.cmd
> 
>   DEVELOPERS                                    |  4 +++
>   board/cubietech/cubieboard1/genimage.cfg      | 16 +++++++++
>   board/cubietech/cubieboard1/readme.txt        | 29 ++++++++++++++++
>   .../boot/extlinux/extlinux.conf               |  5 +++
>   configs/cubieboard1_defconfig                 | 34 +++++++++++++++++++
>   5 files changed, 88 insertions(+)
>   create mode 100644 board/cubietech/cubieboard1/genimage.cfg
>   create mode 100644 board/cubietech/cubieboard1/readme.txt
>   create mode 100644 board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
>   create mode 100644 configs/cubieboard1_defconfig
> 
> --
> 2.25.1
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 6ffa3ee693..82f2f8c8cd 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1137,6 +1137,10 @@ F:	package/flannel/
>   N:	Geoffrey Ragot <geoffreyragot@gmail.com>
>   F:	package/python-pyyaml/
> 
> +N:	Gero Schwaericke <gero@schwaericke.email>
> +F:	board/cubietech/cubieboard1/
> +F:	configs/cubieboard1_defconfig
> +
>   N:	Gilles Talis <gilles.talis@gmail.com>
>   F:	board/freescale/imx8mmevk/
>   F:	board/friendlyarm/nanopi-r2s/
> diff --git a/board/cubietech/cubieboard1/genimage.cfg b/board/cubietech/cubieboard1/genimage.cfg
> new file mode 100644
> index 0000000000..92c8677545
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/genimage.cfg
> @@ -0,0 +1,16 @@
> +image sdcard.img {
> +	hdimage {
> +	}
> +
> +	partition u-boot {
> +		in-partition-table = "no"
> +		image = "u-boot-sunxi-with-spl.bin"
> +		offset = 8K
> +		size = 1016K # 1MB - 8KB
> +	}
> +
> +	partition rootfs {
> +		partition-type = 0x83
> +		image = "rootfs.ext4"
> +	}
> +}
> diff --git a/board/cubietech/cubieboard1/readme.txt b/board/cubietech/cubieboard1/readme.txt
> new file mode 100644
> index 0000000000..294b4e5eec
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/readme.txt
> @@ -0,0 +1,29 @@
> +Cubietech Cubieboard1
> +=====================
> +
> +Minimal configuration for the Cubietech Cubieboard1. It includes just what is
> +needed to boot a bare Linux and login via serial console.
> +
> +
> +Building
> +========
> +
> +Configure and build with
> +
> +	make cubieboard1_defconfig
> +	make
> +
> +
> +Flashing
> +========
> +
> +Flash the sdcard image onto a micro sdcard with
> +
> +	dd if=output/images/sdcard.img of=/dev/sdX bs=1M conv=fsync
> +
> +
> +Running
> +=======
> +
> +Connect a 3V3 serial interface to the serial header on the top side of the board
> +(between the USB jacks and the A10 chip). Then provide power to the board.
> diff --git a/board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf b/board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
> new file mode 100644
> index 0000000000..2fde683f38
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
> @@ -0,0 +1,5 @@
> +DEFAULT linux
> +LABEL linux
> +  KERNEL /boot/zImage
> +  DEVICETREE /boot/sun4i-a10-cubieboard.dtb
> +  APPEND console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p1 rootwait
> diff --git a/configs/cubieboard1_defconfig b/configs/cubieboard1_defconfig
> new file mode 100644
> index 0000000000..7ef20db669
> --- /dev/null
> +++ b/configs/cubieboard1_defconfig
> @@ -0,0 +1,34 @@
> +# Architecture
> +BR2_arm=y
> +BR2_cortex_a8=y
> +
> +# Toolchain options
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_4=y
> +
> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.07"
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="Cubieboard"
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.4.9"
> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun4i-a10-cubieboard"
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +
> +# Filesystem
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_ROOTFS_OVERLAY="board/cubietech/cubieboard1/rootfs_overlay"
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/cubietech/cubieboard1/genimage.cfg"

I've build tested successfully using utils/docker-run and the rest looks
good to me so:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot