Re: [PATCH 1/8] wil6210: dump Rx status message on errors

[merez@codeaurora.org]

On 2019-12-18 16:31, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
> 
>> Maya Erez <merez@codeaurora.org> writes:
>> 
>>> From: Ahmad Masri <amasri@codeaurora.org>
>>> 
>>> Dump all the Rx status message on different errors to allow more
>>> visibility of the case.
>>> 
>>> Signed-off-by: Ahmad Masri <amasri@codeaurora.org>
>>> Signed-off-by: Maya Erez <merez@codeaurora.org>
>>> ---
>>>  drivers/net/wireless/ath/wil6210/txrx_edma.c | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>> 
>>> diff --git a/drivers/net/wireless/ath/wil6210/txrx_edma.c 
>>> b/drivers/net/wireless/ath/wil6210/txrx_edma.c
>>> index 02548d40253c..6a1671c3a2be 100644
>>> --- a/drivers/net/wireless/ath/wil6210/txrx_edma.c
>>> +++ b/drivers/net/wireless/ath/wil6210/txrx_edma.c
>>> @@ -903,6 +903,11 @@ static struct sk_buff 
>>> *wil_sring_reap_rx_edma(struct wil6210_priv *wil,
>>>  	if (unlikely(!wil_val_in_range(buff_id, 1, 
>>> wil->rx_buff_mgmt.size))) {
>>>  		wil_err(wil, "Corrupt buff_id=%d, sring->swhead=%d\n",
>>>  			buff_id, sring->swhead);
>>> +		print_hex_dump(KERN_ERR, "RxS ", DUMP_PREFIX_OFFSET, 16, 1,
>>> +			       (void *)msg, wil->use_compressed_rx_status ?
>> 
>> Isn't the cast unnecessary? Please avoid casting as much as possible.
>> 
>>> @@ -963,6 +968,11 @@ static struct sk_buff 
>>> *wil_sring_reap_rx_edma(struct wil6210_priv *wil,
>>> 
>>>  	if (unlikely(dmalen > sz)) {
>>>  		wil_err(wil, "Rx size too large: %d bytes!\n", dmalen);
>>> +		print_hex_dump(KERN_ERR, "RxS ", DUMP_PREFIX_OFFSET, 16, 1,
>>> +			       (void *)msg, wil->use_compressed_rx_status ?
>> 
>> Same here.
> 
> I fixed these in the pending branch, please double check:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=51d652cdee36051bdb83809adb91951f41c7a456

Thanks for fixing it. The fix looks good.