Re: [PATCH net-next] r8169: set EEE speed down ratio to 1

[Heiner Kallweit <hkallweit1@gmail.com>]

On 9/17/2025 4:48 PM, Hau wrote:
>>
>> External mail : This email originated from outside the organization. Do not
>> reply, click links, or open attachments unless you recognize the sender and
>> know the content is safe.
>>
>>
>>
>> On 9/4/2025 4:11 AM, ChunHao Lin wrote:
>>> EEE speed down ratio (mac ocp 0xe056[7:4]) is used to control EEE
>>> speed down rate. The larger this value is, the more power can save.
>>> But it actually save less power then expected, but will impact
>>> compatibility. So set it to 1 (mac ocp 0xe056[7:4] = 0) to improve
>> compatibility.
>>>
>>> Signed-off-by: ChunHao Lin <hau@realtek.com>
>>> ---
>>
>> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> This patch seems has been reviewed. But I did not see it been accepted. Should I resubmit the patch?

Its status in patchwork is "changes requested", likely due to the fact that we had a conversation
about the patch. So yes, please resubmit, with my Rb, and best also add the following, that you wrote,
to the commit message.

It means clock (MAC MCU) speed down. It is not from spec, so it is kind of Realtek specific feature.
It may cause packet drop or interrupt loss (different hardware may have different issue).