From: "Moger, Babu" <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Cc: fenghua.yu@intel.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, paulmck@kernel.org,
akpm@linux-foundation.org, quic_neeraju@quicinc.com,
rdunlap@infradead.org, damien.lemoal@opensource.wdc.com,
songmuchun@bytedance.com, peterz@infradead.org,
jpoimboe@kernel.org, pbonzini@redhat.com,
chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
jmattson@google.com, daniel.sneddon@linux.intel.com,
sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
bagasdotme@gmail.com, eranian@google.com,
christophe.leroy@csgroup.eu, jarkko@kernel.org,
adrian.hunter@intel.com, quic_jiles@quicinc.com,
peternewman@google.com
Subject: Re: [PATCH v10 07/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config()
Date: Thu, 5 Jan 2023 09:48:57 -0600 [thread overview]
Message-ID: <0c8e83e6-c299-fdf3-1528-b97d578438b2@amd.com> (raw)
In-Reply-To: <6597dab2-db66-e4c1-e8e2-b18b2a0bc9e3@intel.com>
On 1/4/23 18:28, Reinette Chatre wrote:
> Hi Babu,
>
> On 12/22/2022 3:31 PM, Babu Moger wrote:
>> In an upcoming change rdt_get_mon_l3_config() needs to call
>> rdt_cpu_has() to query the monitor related features. It cannot be
>> called right now because rdt_cpu_has() has the __init attribute but
>> rdt_get_mon_l3_config() doesn't.
>>
>> Add the __init attribute to rdt_get_mon_l3_config() that is only called
>> by get_rdt_mon_resources() that already has the __init attribute. Also
>> make rdt_cpu_has() available to by rdt_get_mon_l3_config() via
>> the internal header file.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Thank you.
>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Thank You
Babu
>
> Reinette
--
Thanks
Babu Moger
next prev parent reply other threads:[~2023-01-05 15:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 23:31 [PATCH v10 00/13] x86/resctrl: Support for AMD QoS new features Babu Moger
2022-12-22 23:31 ` [PATCH v10 01/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2023-01-05 0:28 ` Reinette Chatre
2023-01-05 15:48 ` Moger, Babu
2022-12-22 23:31 ` [PATCH v10 02/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2022-12-22 23:31 ` [PATCH v10 03/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2022-12-22 23:31 ` [PATCH v10 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2022-12-22 23:31 ` [PATCH v10 05/13] x86/resctrl: Include new features in command line options Babu Moger
2022-12-22 23:31 ` [PATCH v10 06/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2022-12-22 23:31 ` [PATCH v10 07/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() Babu Moger
2023-01-05 0:28 ` Reinette Chatre
2023-01-05 15:48 ` Moger, Babu [this message]
2022-12-22 23:31 ` [PATCH v10 08/13] x86/resctrl: Support monitor configuration Babu Moger
2022-12-22 23:31 ` [PATCH v10 09/13] x86/resctrl: Add interface to read mbm_total_bytes_config Babu Moger
2023-01-05 0:29 ` Reinette Chatre
2023-01-05 15:49 ` Moger, Babu
2022-12-22 23:31 ` [PATCH v10 10/13] x86/resctrl: Add interface to read mbm_local_bytes_config Babu Moger
2022-12-22 23:31 ` [PATCH v10 11/13] x86/resctrl: Add interface to write mbm_total_bytes_config Babu Moger
2023-01-05 0:29 ` Reinette Chatre
2023-01-05 16:04 ` Moger, Babu
2023-01-05 17:49 ` Reinette Chatre
2023-01-05 19:59 ` Moger, Babu
2022-12-22 23:31 ` [PATCH v10 12/13] x86/resctrl: Add interface to write mbm_local_bytes_config Babu Moger
2022-12-22 23:31 ` [PATCH v10 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2023-01-05 0:30 ` Reinette Chatre
2023-01-05 16:06 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c8e83e6-c299-fdf3-1528-b97d578438b2@amd.com \
--to=babu.moger@amd.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=quic_jiles@quicinc.com \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.