From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Kristian Brox <isyourbrainfoss@proton.me>, oe-linux-nfc@lists.linux.dev
Cc: david@ixit.cz, krzk+dt@kernel.org, devicetree@vger.kernel.org,
dmitry.baryshkov@oss.qualcomm.com, luca.weiss@fairphone.com,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: add ST21NFCD NFC
Date: Mon, 24 Aug 2026 10:57:11 +0200 [thread overview]
Message-ID: <0cc4dcb5-cc90-46cd-9174-029416e7f51d@oss.qualcomm.com> (raw)
In-Reply-To: <20260819210906.2500789-4-isyourbrainfoss@proton.me>
On 8/19/26 11:09 PM, Kristian Brox wrote:
> Enable the ST21NFCD on i2c9 (0x08), IRQ TLMM 41, reset TLMM 38
> active-high. Compatible is st,st21nfcd (raw NCI).
>
> SYS_CLK is LN_BB_CLK2. VPS_IO is L18B (vreg_l18b). ese-present and
> uicc-present follow the public schematic (NFC_SWP1/SWP2: SWP_SE to
> SIM1, SWP_UICC to SIM2). Reader path is tested; SE/HCE is not.
>
> Signed-off-by: Kristian Brox <isyourbrainfoss@proton.me>
> ---
[...]
> + nfc_reset_default: nfc-reset-default-state {
> + pins = "gpio38";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
This line is unnecessary, the driver should assert the pin
otherwise
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-08-24 8:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:59 [PATCH 0/3] nfc: st-nci: Fairphone 5 NFC bring-up (ST21NFCD) Kristian Brox
2026-08-18 20:59 ` [PATCH 1/3] dt-bindings: net: nfc: add st,st21nfcd-i2c Kristian Brox
2026-08-18 23:07 ` Dmitry Baryshkov
2026-08-18 23:22 ` David Heidelberg
2026-08-19 6:18 ` Krzysztof Kozlowski
2026-08-18 20:59 ` [PATCH 2/3] nfc: st-nci: add raw NCI path for ST21NFCD Kristian Brox
2026-08-18 21:00 ` [PATCH 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: add ST21NFCD NFC Kristian Brox
2026-08-19 8:58 ` Konrad Dybcio
2026-08-19 9:02 ` Konrad Dybcio
2026-08-19 15:10 ` Luca Weiss
2026-08-19 21:09 ` [PATCH v2 0/3] nfc: st-nci: Fairphone 5 NFC bring-up (ST21NFCD) Kristian Brox
2026-08-19 21:09 ` [PATCH v2 1/3] dt-bindings: net: nfc: add st,st21nfcd Kristian Brox
2026-08-19 21:47 ` David Heidelberg
2026-08-20 6:05 ` Krzysztof Kozlowski
2026-08-19 21:09 ` [PATCH v2 2/3] nfc: st-nci: add raw NCI path for ST21NFCD Kristian Brox
2026-08-20 21:10 ` sashiko-bot
2026-08-19 21:09 ` [PATCH v2 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: add ST21NFCD NFC Kristian Brox
2026-08-19 21:54 ` David Heidelberg
2026-08-20 21:09 ` sashiko-bot
2026-08-24 8:57 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc4dcb5-cc90-46cd-9174-029416e7f51d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=isyourbrainfoss@proton.me \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.