From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D46C433EF for ; Thu, 9 Sep 2021 22:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F69260ED8 for ; Thu, 9 Sep 2021 22:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345555AbhIIW6E (ORCPT ); Thu, 9 Sep 2021 18:58:04 -0400 Received: from mga14.intel.com ([192.55.52.115]:38575 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244256AbhIIW6E (ORCPT ); Thu, 9 Sep 2021 18:58:04 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="220610022" X-IronPort-AV: E=Sophos;i="5.85,281,1624345200"; d="scan'208";a="220610022" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 15:56:53 -0700 X-IronPort-AV: E=Sophos;i="5.85,281,1624345200"; d="scan'208";a="694374571" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.212.200.87]) ([10.212.200.87]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 15:56:52 -0700 Subject: Re: [PATCH v2] perf list: Display hybrid pmu events with cpu type To: Ian Rogers , Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com References: <20210903025239.22754-1-yao.jin@linux.intel.com> From: Andi Kleen Message-ID: <0ccb62bf-34be-b986-4794-d8cc2a767a3e@linux.intel.com> Date: Thu, 9 Sep 2021 15:56:51 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 9/9/2021 3:37 PM, Ian Rogers wrote: > On Thu, Sep 2, 2021 at 7:54 PM Jin Yao wrote: >> Add a new option '--cputype' to perf-list to display core-only pmu events >> or atom-only pmu events. >> >> Each hybrid pmu event has been assigned with a pmu name, this patch >> compares the pmu name before listing the result. > Would this work more broadly for any PMU type? If so perhaps pmu > rather than cputype is a more appropriate option name? It's not just the cpu pmu, because it still lists the uncore events, which makes sense. If you want to match the pmu it probably would make sense to match it in the default matching for non option arguments in perf list. But that would be a different patch. -Andi