From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] Xen: Update compiler checks
Date: Thu, 20 Mar 2025 16:43:04 +0100 [thread overview]
Message-ID: <0d0197b1-61d2-48ef-94a9-d2fbf1d7d073@suse.com> (raw)
In-Reply-To: <20250320153241.43809-3-andrew.cooper3@citrix.com>
On 20.03.2025 16:32, Andrew Cooper wrote:
> --- a/xen/include/xen/compiler.h
> +++ b/xen/include/xen/compiler.h
> @@ -1,18 +1,10 @@
> #ifndef __LINUX_COMPILER_H
> #define __LINUX_COMPILER_H
>
> -#if !defined(__GNUC__) || (__GNUC__ < 4)
> -#error Sorry, your compiler is too old/not recognized.
> -#elif CONFIG_CC_IS_GCC
> -# if defined(CONFIG_ARM_32) && CONFIG_GCC_VERSION < 40900
> -# error Sorry, your version of GCC is too old - please use 4.9 or newer.
> -# elif defined(CONFIG_ARM_64) && CONFIG_GCC_VERSION < 50100
> -/*
> - * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293
> - * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk
> - */
> -# error Sorry, your version of GCC is too old - please use 5.1 or newer.
> -# endif
> +#if CONFIG_CC_IS_GCC && CONFIG_GCC_VERSION < 50100
> +# error Sorry, your version of GCC is too old - please use 5.1 or newer
> +#elif CONFIG_CC_IS_CLANG && CONFIG_CLANG_VERSION < 110000
> +# error Sorry, your version of Clang is too old - please use 11 or newer
> #endif
While the Arm special cases can now indeed go away, shouldn't a RISC-V one
appear instead, seeing what ./README says?
Jan
next prev parent reply other threads:[~2025-03-20 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 15:32 [PATCH 0/3] Xen: CI changes for new toolchain baseline Andrew Cooper
2025-03-20 15:32 ` [PATCH 2/3] Xen: Update compiler checks Andrew Cooper
2025-03-20 15:43 ` Jan Beulich [this message]
2025-03-20 15:32 ` [PATCH 3/3] CHANGELOG: Minimum toolchain requirements Andrew Cooper
2025-03-20 15:44 ` Jan Beulich
2025-03-21 16:20 ` Oleksii Kurochko
-- strict thread matches above, loose matches on Subject: below --
2025-03-20 15:59 [PATCH RESEND 0/3] Xen: CI changes for new toolchain baseline Andrew Cooper
2025-03-20 15:59 ` [PATCH 2/3] Xen: Update compiler checks Andrew Cooper
2025-03-21 22:10 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0197b1-61d2-48ef-94a9-d2fbf1d7d073@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.