From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Robin Jarry <rjarry@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>
Subject: Re: [PATCH dpdk] net: add more icmp types and code
Date: Thu, 17 Oct 2024 23:22:01 +0100 [thread overview]
Message-ID: <0d0c4a30-372e-4b68-a52f-e525bd2d21e9@amd.com> (raw)
In-Reply-To: <20241017090258.289a0aaf@hermes.local>
On 10/17/2024 5:02 PM, Stephen Hemminger wrote:
> On Thu, 17 Oct 2024 10:33:22 +0200
> Robin Jarry <rjarry@redhat.com> wrote:
>
>> Add more ICMP message types and codes based on RFC 792. Change the
>> namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation
>> between types and codes.
>>
>> Signed-off-by: Robin Jarry <rjarry@redhat.com>
>
> Should add a release note for this
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
+1 to get this in 24.11
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
@Thomas, probably it is better to get this for -rc1 and as next-net
already pulled can this directly go to main?
Btw, is following also required? Just because it is documented in RFC:
15 Information Request
16 Information Reply
Ack stands if above added or not.
next prev parent reply other threads:[~2024-10-17 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 8:33 [PATCH dpdk] net: add more icmp types and code Robin Jarry
2024-10-17 16:02 ` Stephen Hemminger
2024-10-17 22:22 ` Ferruh Yigit [this message]
2024-10-17 22:33 ` Robin Jarry
2024-10-17 22:48 ` Ferruh Yigit
2024-10-17 22:41 ` [PATCH dpdk v2] " Robin Jarry
2024-10-18 0:39 ` Morten Brørup
2024-10-18 15:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0c4a30-372e-4b68-a52f-e525bd2d21e9@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.