All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
	Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>,
	linux-ide@vger.kernel.org
Cc: stable@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH] ata: sata_inic162x: remove dangerous broken driver
Date: Tue, 15 Sep 2026 10:24:09 +0700	[thread overview]
Message-ID: <0d24bc04-a9e2-4aeb-8199-428c657a3b34@kernel.org> (raw)
In-Reply-To: <20260915014714.41274-1-enelsonmoore@gmail.com>

On 2026/09/15 8:47, Ethan Nelson-Moore wrote:
> The sata_inic162x driver was labeled as "very experimental" in
> commit bb9696192826 ("libata: make it clear that sata_inic162x is
> experimental") due to data corruption issues, but not marked as broken.
> Since then, no changes have been made to it that could fix these
> issues. Since the driver was not marked as broken, and the message
> about potential data corruption is only visible in the code and dmesg,
> it is possible that someone could enable the driver without realizing
> its potential for data corruption. Remove the driver to protect users'
> data.
> 
> Fixes: 1fd7a697a37b ("sata_inic162x: finally, driver for initio 162x SATA controllers, take #2")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>

The normal approach would be to first deprecate the driver, and then remove it
(some time later, generally one year). But given the broken nature of this
driver, and since there was no fixes (beside cosmetic/API changes) since 2013
when the warning was added, I have no problem with outright removing it. So:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-09-15  3:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  1:47 [PATCH] ata: sata_inic162x: remove dangerous broken driver Ethan Nelson-Moore
2026-09-15  3:24 ` Damien Le Moal [this message]
2026-09-15  6:52 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d24bc04-a9e2-4aeb-8199-428c657a3b34@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=enelsonmoore@gmail.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.