All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Orzel, Michal" <michal.orzel@amd.com>
To: Daisuke Nishimura <nishimura@valinux.co.jp>,
	<xen-devel@lists.xenproject.org>
Cc: Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH] xen/arm: its: only clean cache when sending ITS command
Date: Tue, 17 Nov 2026 08:45:27 +0100	[thread overview]
Message-ID: <0d253cc7-486a-428e-bb4d-b4ce2ebf530c@amd.com> (raw)
In-Reply-To: <20261117033217.184625-1-nishimura@valinux.co.jp>



On 17-Nov-26 04:32, Daisuke Nishimura wrote:
> From: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> 
> There is no need to invalidate cache entry because we just wrote that
> memory. So it is guaranteed that cache entry is valid.
I don't think this is a good rationale. What makes invalidation not
needed here is that the CPU is the only writer and the ITS the only
reader of this buffer, so the cached data cannot be stale. Invalidation
would be needed if a device wrote a buffer that the CPU later reads.

> 
> But we need to clean (flush) cache line to be sure that ITS sees
flush means clean+invalidate, which is what you drop, so please drop "flush" word.

> command written into the memory.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> Signed-off-by: Daisuke Nishimura <nishimura@valinux.co.jp>
With that:
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal



  reply	other threads:[~2026-11-17  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  3:32 [PATCH] xen/arm: its: only clean cache when sending ITS command Daisuke Nishimura
2026-11-17  7:45 ` Orzel, Michal [this message]
2026-11-18  0:11   ` Daisuke Nishimura
2026-11-18  2:15 ` [PATCH v2] " Daisuke Nishimura
  -- strict thread matches above, loose matches on Subject: below --
2026-11-17  2:45 [PATCH] " Daisuke Nishimura
2026-11-17  3:17 ` Daisuke Nishimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d253cc7-486a-428e-bb4d-b4ce2ebf530c@amd.com \
    --to=michal.orzel@amd.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=nishimura@valinux.co.jp \
    --cc=sstabellini@kernel.org \
    --cc=volodymyr_babchuk@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.