From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083B8C433FE for ; Mon, 7 Dec 2020 19:13:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98C6E23406 for ; Mon, 7 Dec 2020 19:13:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C6E23406 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46948.83154 (Exim 4.92) (envelope-from ) id 1kmLwg-0003is-8o; Mon, 07 Dec 2020 19:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46948.83154; Mon, 07 Dec 2020 19:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmLwg-0003il-4q; Mon, 07 Dec 2020 19:13:14 +0000 Received: by outflank-mailman (input) for mailman id 46948; Mon, 07 Dec 2020 19:13:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmLwe-0003ig-87 for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 19:13:12 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a03cd1b4-4776-483c-b591-2348ce19a3de; Mon, 07 Dec 2020 19:13:10 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id i2so13881925wrs.4 for ; Mon, 07 Dec 2020 11:13:10 -0800 (PST) Received: from CBGR90WXYV0 (host86-183-162-145.range86-183.btcentralplus.com. [86.183.162.145]) by smtp.gmail.com with ESMTPSA id u10sm195629wmd.43.2020.12.07.11.13.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Dec 2020 11:13:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a03cd1b4-4776-483c-b591-2348ce19a3de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=mKImpMHefcGMjwuZymDE86va3HkD31kS1uQWZsITmds=; b=rfT/Ep6s4v0B1xbYfnA75do4KB6pJ0V7gW8HHP6HqNT4+mv6BVoIp8qJUmxkMdEpc7 XqssnJYS2TtqWZJTIHyUHXEyPoZ9cQBrmCUxb4TMkU2JyK5ckegjowPLj6fjxRVvM8IX GAj1u7TvJBeXLrHSA355NYJXrAQiilhsfrBkEVyG53NEv6cKtrK0ABE4f6cbMl6B4PiI 8Apz9wZIB0gAHHbS5VlsLCK0raQEgkEkr+b3JkmYWt7h7uhD4p8hCWsV5l/GAMUG+9Fo ghJjtwyFYmpHDJR6g1kn05Qg43sjiiXBmpAKZX7XUkWgYGyG8iZkzVKFS1kE/8Pk9LuX YZOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=mKImpMHefcGMjwuZymDE86va3HkD31kS1uQWZsITmds=; b=nxniQ3knFQK5EWoqGGyR+P6jaMSMK6nSa9Nbw4G78ZQ8ysVxwX02T8uxWpBhrlolf7 /8Keg3L6SdhkWQPa6NHEgArfctLCjRwoWbH33ePOeTNB9ha9i0SEf1hudTomBJCpL3u6 uWhNkBnvvPQCst8LffzGaersvRU/7qrc/US5j9xOrbEsNMH/r4kCTqcEhSY7CKQxQeyN +59usKBwZWNOxfBiRpFFBVfmrhxTODsZidax5XYYfNMria1IlqN0bEE1ONQ8ZBAGZyK7 X4K/S1KTJRgYK+XAnAX+DnKv4HepNC+gUvQtyEJX4cYRqWubs4P5FEDPUBRdw+AfL2so E4fg== X-Gm-Message-State: AOAM533Ld5nR0031Oi7MoNUvd1YYPSFE+ffsTS9Mbu6fLZkcGi4FAq4Q iGnakDaTgELMYO+hfSZpKUE= X-Google-Smtp-Source: ABdhPJxUNUMRg4txWxb/8/bsuceumcDwSZaTvlnQGXtEc1QkLnwk35GphjW3ed+ojEDRta9qcPAkjg== X-Received: by 2002:adf:fa4a:: with SMTP id y10mr21526240wrr.122.1607368389799; Mon, 07 Dec 2020 11:13:09 -0800 (PST) From: Paul Durrant X-Google-Original-From: "Paul Durrant" Reply-To: To: "'Wei Liu'" Cc: , "'Paul Durrant'" , "'Ian Jackson'" , "'Anthony PERARD'" References: <20201203142534.4017-1-paul@xen.org> <20201203142534.4017-19-paul@xen.org> <20201204113413.iebyf2ldzq6rfpsg@liuwe-devbox-debian-v2> In-Reply-To: <20201204113413.iebyf2ldzq6rfpsg@liuwe-devbox-debian-v2> Subject: RE: [PATCH v5 18/23] libxlu: introduce xlu_pci_parse_spec_string() Date: Mon, 7 Dec 2020 19:13:08 -0000 Message-ID: <0d2e01d6cccc$ffe23da0$ffa6b8e0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQLNnXLs2pPLw4H6lzH6w2mINWFu0wIe2fTUAq/cxhCn1+ivcA== > -----Original Message----- > From: Wei Liu > Sent: 04 December 2020 11:34 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Ian Jackson > ; Wei Liu ; Anthony PERARD > Subject: Re: [PATCH v5 18/23] libxlu: introduce xlu_pci_parse_spec_string() > > On Thu, Dec 03, 2020 at 02:25:29PM +0000, Paul Durrant wrote: > > From: Paul Durrant > > > > This patch largely re-writes the code to parse a PCI_SPEC_STRING and enters > > it via the newly introduced function. The new parser also deals with 'bdf' > > and 'vslot' as non-positional paramaters, as per the documentation in > > xl-pci-configuration(5). > > > > The existing xlu_pci_parse_bdf() function remains, but now strictly parses > > BDF values. Some existing callers of xlu_pci_parse_bdf() are > > modified to call xlu_pci_parse_spec_string() as per the documentation in xl(1). > > > > NOTE: Usage text in xl_cmdtable.c and error messages are also modified > > appropriately. > > > > Fixes: d25cc3ec93eb ("libxl: workaround gcc 10.2 maybe-uninitialized warning") > > I don't think d25cc3ec93eb is buggy, so this tag is not needed. It is. If you supply the '*' for all funcs then vfunc_mask is set but func is not... so you then hit the assertion at the end of xlu_pci_parse_bdf(). > > > Signed-off-by: Paul Durrant > > Acked-by: Wei Liu Thanks, Paul