From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: unconditionally unlock panel regs Date: Tue, 14 Dec 2010 20:45:14 +0000 Message-ID: <0d30dc$kf996t@orsmga001.jf.intel.com> References: <20101214121759.11b8aa3a@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C8839E9BA for ; Tue, 14 Dec 2010 12:45:28 -0800 (PST) In-Reply-To: <20101214121759.11b8aa3a@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 14 Dec 2010 12:17:59 -0800, Jesse Barnes wrote: > In the panel_on function we skip everything if the panel is already > powered up. However, if it's powered up but not unlocked, subsequent > register writes may fail. > > So unlock the regs regardless of the panel state to allow other mode > setting programming to occur normally. That looks to be consistent with other [ab]users of PP_CONTROL. Can you tidy up the function to remove the duplicate code afterwards? -Chris -- Chris Wilson, Intel Open Source Technology Centre