From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] configure: updated m4 macro check in configure.ac Date: Tue, 21 Dec 2010 22:33:35 +0000 Message-ID: <0d30dc$khhefu@orsmga001.jf.intel.com> References: <1292969441-3601-1-git-send-email-ullysses.a.eoff@intel.com> <87fwtqdavt.fsf@yoom.home.cworth.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D6DA9E9D2 for ; Tue, 21 Dec 2010 14:33:38 -0800 (PST) In-Reply-To: <87fwtqdavt.fsf@yoom.home.cworth.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Carl Worth , "U. Artie Eoff" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 21 Dec 2010 14:22:30 -0800, Carl Worth wrote: > On Tue, 21 Dec 2010 15:10:41 -0700, "U. Artie Eoff" wrote: > > Added m4 check for XORG_DRIVER_CHECK_EXT macro definition. Updated m4 > > fatal messages to give better hint on how to resolve error when xorg > > macros are missing. Previously, configure would continue in spite of > > the missing macros and the build would fail for syntax errors. > > Thanks so much, Artie! > > I've now pushed this change out. > > Only just after pushing it did I notice that the commit message is all > one long line. No big deal for this commit, but in future commits, if > you wrap that paragraph to fit within 80 columns then some tools will > display the commit message more cleanly. And the duplicated string without mentioning the upstream source... -Chris -- Chris Wilson, Intel Open Source Technology Centre