From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009Ab1APLHh (ORCPT ); Sun, 16 Jan 2011 06:07:37 -0500 Received: from mga02.intel.com ([134.134.136.20]:26259 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839Ab1APLHg (ORCPT ); Sun, 16 Jan 2011 06:07:36 -0500 Message-Id: <0d30dc$kp159h@orsmga001.jf.intel.com> X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.60,329,1291622400"; d="scan'208";a="697341233" Date: Sun, 16 Jan 2011 11:07:32 +0000 To: Felipe Balbi , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm: fixup headers_check Cc: Felipe Balbi , David Airlie , dri-devel@lists.freedesktop.org References: <1295174783-4099-1-git-send-email-balbi@ti.com> From: Chris Wilson In-Reply-To: <1295174783-4099-1-git-send-email-balbi@ti.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi wrote: > Drop the following headers_check errors: > /linux-2.6/usr/include/drm/drm_mode.h:85: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/i915_drm.h:120: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/mga_drm.h:260: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/radeon_drm.h:758: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/via_drm.h:117: found > __[us]{8,16,32,64} type without #include > > Cc: David Airlie > Cc: Chris Wilson > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Felipe Balbi > --- > include/drm/drm_mode.h | 2 ++ > include/drm/i915_drm.h | 1 + > include/drm/mga_drm.h | 1 + > include/drm/radeon_drm.h | 1 + > include/drm/via_drm.h | 1 + > 5 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h > index 0fc7397..1678d7b 100644 > --- a/include/drm/drm_mode.h > +++ b/include/drm/drm_mode.h > @@ -27,6 +27,8 @@ > #ifndef _DRM_MODE_H > #define _DRM_MODE_H > > +#include > + Would #if 0 #include /* silence make header_check */ #endif be an acceptable compromise? -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm: fixup headers_check Date: Sun, 16 Jan 2011 11:07:32 +0000 Message-ID: <0d30dc$kp159h@orsmga001.jf.intel.com> References: <1295174783-4099-1-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id F41829E75C for ; Sun, 16 Jan 2011 03:07:35 -0800 (PST) In-Reply-To: <1295174783-4099-1-git-send-email-balbi@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Felipe Balbi List-Id: dri-devel@lists.freedesktop.org On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi wrote: > Drop the following headers_check errors: > /linux-2.6/usr/include/drm/drm_mode.h:85: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/i915_drm.h:120: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/mga_drm.h:260: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/radeon_drm.h:758: found > __[us]{8,16,32,64} type without #include > /linux-2.6/usr/include/drm/via_drm.h:117: found > __[us]{8,16,32,64} type without #include > > Cc: David Airlie > Cc: Chris Wilson > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Felipe Balbi > --- > include/drm/drm_mode.h | 2 ++ > include/drm/i915_drm.h | 1 + > include/drm/mga_drm.h | 1 + > include/drm/radeon_drm.h | 1 + > include/drm/via_drm.h | 1 + > 5 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h > index 0fc7397..1678d7b 100644 > --- a/include/drm/drm_mode.h > +++ b/include/drm/drm_mode.h > @@ -27,6 +27,8 @@ > #ifndef _DRM_MODE_H > #define _DRM_MODE_H > > +#include > + Would #if 0 #include /* silence make header_check */ #endif be an acceptable compromise? -Chris -- Chris Wilson, Intel Open Source Technology Centre