From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <bwidawsk@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm/i915/context
Date: Wed, 02 Feb 2011 23:29:37 +0000 [thread overview]
Message-ID: <0d30dc$kupvbd@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1296687620-27019-1-git-send-email-bwidawsk@gmail.com>
I don't think we should be pinning contexts for their entire lifetime.
The page should only be pinned whilst it is being referenced by the
hardware, and it looks like you already parts of the infrastructure to
be able to track this. You will also need to track seqno and retire
contexts...
Being picky, there are still renames ;-) But it is much easier to see
what you are introducing in each step, thanks!
I'm not convinced by the locking strategy, there seems to be quite a few
holes left, and is something else that is much easier to make it correct
from the beginning and incrementally adjust.
And then there are lots of little changes to try and make the code
tidier... But those are probably best left for another day.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-02-02 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 23:00 [PATCH 0/8] drm/i915/context Ben Widawsky
2011-02-02 23:00 ` [PATCH 1/8] drm/i915/context: basic implementation context ioctls Ben Widawsky
2011-02-02 23:00 ` [PATCH 2/8] drm/i915/context: context initialization/destruction Ben Widawsky
2011-02-02 23:00 ` [PATCH 3/8] drm/i915/context: whitespace cleanup, and warning cleanup Ben Widawsky
2011-02-02 23:00 ` [PATCH 4/8] drm/i915/context: minimal support for contexts in execbuffer2 Ben Widawsky
2011-02-02 23:00 ` [PATCH 5/8] drm/i915/context: context validation for execbuffer2 Ben Widawsky
2011-02-14 20:21 ` Daniel Vetter
2011-02-14 23:10 ` Ben Widawsky
2011-02-02 23:00 ` [PATCH 6/8] drm/i915/context: enable calling context_switch Ben Widawsky
2011-02-02 23:00 ` [PATCH 7/8] drm/i915/context: Insert MI_SET_CONTEXT in ringbuffer context switch Ben Widawsky
2011-02-02 23:00 ` [PATCH 8/8] drm/i915/context: context switch, and PPGTT params Ben Widawsky
2011-02-02 23:29 ` Chris Wilson [this message]
2011-02-02 23:55 ` [PATCH 0/8] drm/i915/context Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$kupvbd@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=bwidawsk@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.