From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: enabling forcewake from userspace
Date: Sat, 26 Mar 2011 17:18:57 +0000 [thread overview]
Message-ID: <0d30dc$ljrf4q@orsmga001.jf.intel.com> (raw)
In-Reply-To: <20110326154625.GA5068@lundgren.kumite>
On Sat, 26 Mar 2011 08:46:25 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> I think I won't bother trying to upstream my solution. But I'm also
> thinking we should make intel_reg_read/write print a warning/error if
> it's running on GEN6? What do you think?
Adding a code comment or an
if (IS_GEN6 && reg < 0x40000 && FORCE_WAKE == 0) printf("Muppet!\n");
is about as far as I would go. Certainly don't remind us on every
invocation.
> By the way, I do think the patch is beneficial just for kernel usage.
> Right now it doesn't matter, but as more users of the interface pop up,
> particularly in any time sensitive code... wouldn't it be awful if the
> GPU could powerdown while we're servicing an interrupt?
The GPU is definitely allowed to be powered down whilst the CPU is
servicing an interrupt. ;-) I take your point though that the current
method is not interrupt safe. However, we should not be doing such work
from an interrupt handler - if need be all the actual work is kicked off
from a workqueue.
Something we need to keep an eye on, but not a problem today. *touch wood*
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-03-26 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 2:07 enabling forcewake from userspace Ben Widawsky
2011-03-26 2:07 ` [PATCH] drm/i915: have a forcewake "refcount" Ben Widawsky
2011-03-26 2:23 ` enabling forcewake from userspace Ben Widawsky
2011-03-26 7:11 ` Chris Wilson
2011-03-26 15:46 ` Ben Widawsky
2011-03-26 17:18 ` Chris Wilson [this message]
2011-03-26 19:27 ` Ben Widawsky
2011-03-26 20:20 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$ljrf4q@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.