From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 04/16] drm/i915: add Ivy Bridge PCI IDs and flags Date: Wed, 27 Apr 2011 08:23:33 +0100 Message-ID: <0d30dc$m0p91m@orsmga001.jf.intel.com> References: <1303861134-8762-1-git-send-email-jbarnes@virtuousgeek.org> <1303861134-8762-5-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id ACD479EFF8 for ; Wed, 27 Apr 2011 00:23:36 -0700 (PDT) In-Reply-To: <1303861134-8762-5-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 26 Apr 2011 16:38:42 -0700, Jesse Barnes wrote: > Check for IVB desktop, mobile and other SKUs and set flags > appropriately. > > Signed-off-by: Jesse Barnes > --- > static const struct pci_device_id pciidlist[] = { /* aka */ > INTEL_VGA_DEVICE(0x3577, &intel_i830_info), /* I830_M */ > INTEL_VGA_DEVICE(0x2562, &intel_845g_info), /* 845_G */ > @@ -227,6 +241,11 @@ static const struct pci_device_id pciidlist[] = { /* aka */ > INTEL_VGA_DEVICE(0x0116, &intel_sandybridge_m_info), > INTEL_VGA_DEVICE(0x0126, &intel_sandybridge_m_info), > INTEL_VGA_DEVICE(0x010A, &intel_sandybridge_d_info), > + INTEL_VGA_DEVICE(0x0156, &intel_ivybridge_m_info), /* GT1 mobile */ > + INTEL_VGA_DEVICE(0x0166, &intel_ivybridge_m_info), /* GT2 mobile */ > + INTEL_VGA_DEVICE(0x0152, &intel_ivybridge_d_info), /* GT1 desktop */ > + INTEL_VGA_DEVICE(0x0162, &intel_ivybridge_d_info), /* GT2 desktop */ > + INTEL_VGA_DEVICE(0x015a, &intel_ivybridge_d_info), /* GT1 server */ Shouldn't this chunk be the last patch in the series? (First for testing, last for deployment.) -Chris -- Chris Wilson, Intel Open Source Technology Centre