From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] fix interrupt request miss problem in bsd ring for g4x Date: Wed, 27 Apr 2011 08:39:14 +0100 Message-ID: <0d30dc$m0pen7@orsmga001.jf.intel.com> References: <1303812772-5370-1-git-send-email-boqun.feng@intel.com> <749B9D3DBF0F054390025D9EAFF47F224BDFB0E4@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E608A0B9C for ; Wed, 27 Apr 2011 00:39:18 -0700 (PDT) In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F224BDFB0E4@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Feng, Boqun" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, 27 Apr 2011 14:08:57 +0800, "Feng, Boqun" wrote: > I am very sorry for my careless about whitespace. > > But my patch will not affect gen6+ paths, for gen6+, it use gen6_bsd_ring > , bsd_ring is only used by g4x and ironlake. Reviewer error, sorry. Saw the gen6_* in the diff header as the function affected and believed it. > Besides, since bsd_ring_get_irq/bsd_ring_put_irq/ring_get_irq/ring_put_irq > are only used by bsd_ring, can we use a patch to merge them into two function? Yes, once upon a time they differed, now they are the same so please do merge them and give them a more useful name: g4x_ring_* so that there is a constant reminder that g4x also has a BSD ring and that the functions are not expected to be used with earlier chipsets. Daniel has done similar things for gen6 once we decided to drop the pre-production workarounds. Obviously that is a separate patch to the bug fix. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre