From: Paolo Abeni <pabeni@redhat.com>
To: Arun Ramadoss <arun.ramadoss@microchip.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, linux@armlinux.org.uk,
Tristram.Ha@microchip.com, ceggers@arri.de
Subject: Re: [Patch net] net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq
Date: Thu, 15 Dec 2022 12:29:22 +0100 [thread overview]
Message-ID: <0d35858867ae1c3de899d6162aa39e013daff435.camel@redhat.com> (raw)
In-Reply-To: <20221213101440.24667-1-arun.ramadoss@microchip.com>
On Tue, 2022-12-13 at 15:44 +0530, Arun Ramadoss wrote:
> KSZ swithes used interrupts for detecting the phy link up and down.
> During registering the interrupt handler, it used IRQF_TRIGGER_FALLING
> flag. But this flag has to be retrieved from device tree instead of hard
> coding in the driver,
Out of sheer ignorance, why?
> so removing the flag.
It looks like the device tree currently lack such item, so this is
effecivelly breaking phy linkup/linkdown?
What am I missing?
Thanks!
Paolo
next prev parent reply other threads:[~2022-12-15 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 10:14 [Patch net] net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq Arun Ramadoss
2022-12-15 11:29 ` Paolo Abeni [this message]
2022-12-15 13:50 ` Christian Eggers
2022-12-16 4:07 ` Arun.Ramadoss
2022-12-20 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d35858867ae1c3de899d6162aa39e013daff435.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=ceggers@arri.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.