From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1850CAC5B3 for ; Wed, 24 Sep 2025 12:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JJxt3d2F87wvI8Qe3x55ohTxk2SOPeGABJCtecxteNI=; b=C6mDVHTBr+l3HIbGVpBJKK3O9x zZ7mgfWD8H21pj/diWrpGwx7bLdwHAnLbWxf5F6J/nLi9FoNJSzl7xjTYb9yZIHOX8Quyr1fUBJ06 HnGVxRXiOOoeg+Oa6NA/L612/x2RhRLzW+L2EYNscGiXtPs+LnbzU40UltPOWIFIEAcvlNvDuEFxS wOc+WMWdUbQoJRow7L7A7M8b/ajvFzGKyY3HFhux0I9Wn2k5Ux0RA95zfbOkLyYb7YYceGIOqlLQg eSC4fZQmjq6PLPypdL8LsHsq7ZDYMuFa4+rF1cn/S/1MuByWyNC9l9et6DZXuDLkKofoLhF26lfdX ZTfxritw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v1Ooc-0000000HU6M-3Ogj; Wed, 24 Sep 2025 12:41:46 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v1OoY-0000000HU1c-3ab8 for linux-arm-kernel@lists.infradead.org; Wed, 24 Sep 2025 12:41:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758717701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JJxt3d2F87wvI8Qe3x55ohTxk2SOPeGABJCtecxteNI=; b=JPSc53/J3qe/JMWdQKN0RfxoirXl5tFBVw8XTtnGdieWRUz6GJfmS7Fr4/p2o5QFmnjlJX F2QYPvwQuv6qSoFQ9zo/6ti2lpPIiFg1oj8HBuEfnKWSSPRxUGTZUVq1SYzDX0TEf0DwpB f9nbB/thlmxX3ZOSNizDRt/cINIcwxo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-tZ3U_rnePAukoTyCRXZb2g-1; Wed, 24 Sep 2025 08:41:40 -0400 X-MC-Unique: tZ3U_rnePAukoTyCRXZb2g-1 X-Mimecast-MFC-AGG-ID: tZ3U_rnePAukoTyCRXZb2g_1758717699 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3ee13baf21dso6651082f8f.0 for ; Wed, 24 Sep 2025 05:41:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758717699; x=1759322499; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JJxt3d2F87wvI8Qe3x55ohTxk2SOPeGABJCtecxteNI=; b=QUlspVGnRZ1gi4xow/Y7y3Z3CsjDIOOBoQrsIBwgs+zVn4c4UaXloetLWIAKLDh0vs iDpeYXVKzajODMsJlcBtW9QnJ1EHM/sefLx7pXX0JYTMVvtsmenKHRpTHx5P1as+LBic ElHvI3LNyeGFqiLSDE23P2kCNyXgBtQBCnchGt2cyI4NocUwRlOcrSUuqCDXcl9hH+jL VNDNXfuRwBq9fh3jmb9/b3oogEElzKXpogR7VUGWfqp9JFvcSj4Ai50+4CmH6iNtek9P rVPeN3UP03WP9UdCvoFxC3v0MQUzouYWOKir62Ghg7ARNIGT5wnQdY4GUXsJ6dAsSW7s /21w== X-Gm-Message-State: AOJu0Yyqz2JfAyLQx1wZ142B8C/4X29WZLtIv26BrjpHhj/+r9xWQivq 4ddmFg1OCuB/cBKd6iTThb21tOkgcvqMDGGizxcjVDDKQ10nszitq9PPNFpihKtDH/bgjSSxz7G jKOpIM6qfRo9pboqZDIk3n3Qxo4NXmM/DBMHND838wFZVwd6jPbT4ijzQdDTrS2K0zNg34Vcgks z7 X-Gm-Gg: ASbGncuWsRooymNFaG6cthX2kX/f/C56BOOm3dPUeeonWaL5y2uN/BHhLci2rLSdI3n 7qvKBT08BbOGo4UGfACxHmOxv8T1efW34JEm1WTIKI0shnuuTHa0Id5G1cSC+m3Knxsd44xVxmg RynVe2IZUgpIbbAJzsX0HIba89CgvTrt041pP+2NCVp/M6wlfi1ROccONAuKBKnNlX+rm5awv0Z gC1GPTgqpEi4pTrnerWYHA2NmZ1534CG+6NmSRs1WdwJUbo3aaNIbqqISYX0jKr07PFPMPSu9Cp CWhvaek3uQ7RA/JKKqBs7xqk6BUsj92STFAPSuGN1B0B8LAEJIDxKVRzqw64ZQ+XiRN+daHVCFO MU7lNy7HaxR8MGxjlV0y1eN/n+ZM7JesHtTlTob2917CRmYQkHfnpBr2XZZxL4jleFw== X-Received: by 2002:a05:6000:25c8:b0:3e7:4197:c99d with SMTP id ffacd0b85a97d-405c57f88a5mr6288946f8f.15.1758717699120; Wed, 24 Sep 2025 05:41:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHqqbOixBhvaKBIhVYlPl23Lfs3/UjwgQaCkd3TkUHwAqNxh5EIrZUMmDoMSlGXRelnCIlhQ== X-Received: by 2002:a05:6000:25c8:b0:3e7:4197:c99d with SMTP id ffacd0b85a97d-405c57f88a5mr6288921f8f.15.1758717698609; Wed, 24 Sep 2025 05:41:38 -0700 (PDT) Received: from ?IPV6:2003:d8:2f14:2400:afc:9797:137c:a25b? (p200300d82f1424000afc9797137ca25b.dip0.t-ipconnect.de. [2003:d8:2f14:2400:afc:9797:137c:a25b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2ab7d4e3sm30435135e9.23.2025.09.24.05.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Sep 2025 05:41:38 -0700 (PDT) Message-ID: <0d42e745-e146-45eb-80d1-8ce3a6777274@redhat.com> Date: Wed, 24 Sep 2025 14:41:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: mte: Do not flag the zero page as PG_mte_tagged To: Catalin Marinas , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Gergely Kovacs , Lance Yang References: <20250924123528.1536835-1-catalin.marinas@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250924123528.1536835-1-catalin.marinas@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: O25y2_j0m-ppo6uzT5CX-ZeF9byPdJClo44OdCPrhSQ_1758717699 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250924_054142_995961_95313587 X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24.09.25 14:31, Catalin Marinas wrote: > Commit 68d54ceeec0e ("arm64: mte: Allow PTRACE_PEEKMTETAGS access to the > zero page") attempted to fix ptrace() reading of tags from the zero page > by marking it as PG_mte_tagged during cpu_enable_mte(). The same commit > also changed the ptrace() tag access permission check to the VM_MTE vma > flag while turning the page flag test into a WARN_ON_ONCE(). > > Attempting to set the PG_mte_tagged flag early with > CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled may either hang (after commit > d77e59a8fccd "arm64: mte: Lock a page for MTE tag initialisation") or > have the flags cleared later during page_alloc_init_late(). In addition, > pages_identical() -> memcmp_pages() will reject any comparison with the > zero page as it is marked as tagged. > > Partially revert the above commit to avoid setting PG_mte_tagged on the > zero page. Update the __access_remote_tags() warning on untagged pages > to ignore the zero page since it is known to have the tags initialised. > > Note that all user mapping of the zero page are marked as pte_special(). > The arm64 set_pte_at() will not call mte_sync_tags() on such pages, so > PG_mte_tagged will remain cleared. > > Signed-off-by: Catalin Marinas > Fixes: 68d54ceeec0e ("arm64: mte: Allow PTRACE_PEEKMTETAGS access to the zero page") > Reported-by: Gergely Kovacs > Cc: # 5.10.x > Cc: Will Deacon > Cc: David Hildenbrand > Cc: Lance Yang > --- > > For reference, discussion on page merging here: > > https://lore.kernel.org/r/aNKJ5glToE4hMhWA@arm.com > > The deferred struct page init problem was reported by Gergely offline. > > Given that we've had this bug for over four years and it was only > recently noticed, I think we should merge it at -rc1, give it a bit more > time in -next in case it breaks anything (not likely but you never know, > MTE interaction with the mm code is always surprising ;)). Agreed :) LGTM Reviewed-by: David Hildenbrand -- Cheers David / dhildenb