From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6618FC369DC for ; Tue, 29 Apr 2025 17:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lTql7HnDsxiIl3qbXiANCn26wibJ3QtLQajx4ncrD2o=; b=Sx0LW1hQE5lPl+/BummhnARtFM R0vtb4ve0depmpLxd6eL0m/C4B/3LdMKrGloOANj5Sr9wHYSIpfq8U4wMe83qIxZ7FpuKm2kDuz1M m56m/75vrPWPZFicXGPGwCMhslKney7/tA12tCgiZWQpJK3oZ5F9Dr03i9wXEOBCjb6OXkfYtOSnA sieuiiAxOxcsW6xQ/dc+xkvCY28hNNBxjD1vJYF3b49F8lastu/Jko93OYymmI9gWRQ1WtVzKmb2Q 0gTElyZ6P2RLM541Wxnv8oVVacqr2p4Tu0dLGpGvZVhBnm1sPilm4/8I5+EoNhDcE/vlXA1liZhN5 kHfzKwKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9ory-0000000AQQC-3g7n; Tue, 29 Apr 2025 17:35:46 +0000 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9orw-0000000AQPU-0WmP for linux-nvme@lists.infradead.org; Tue, 29 Apr 2025 17:35:45 +0000 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 52E5621206; Tue, 29 Apr 2025 17:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745948142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTql7HnDsxiIl3qbXiANCn26wibJ3QtLQajx4ncrD2o=; b=wHgzt1eEZbBCyK8k7Pdyf3ymTbQPGqq4Ga77Y3M9cYGnyeUOuIx/u8xj2Zy9e/e22McJBa Usi8wTXX9hImndCkAHHe5w3vmJXT4utsLFw6rpjUOTJMPwT8KPC59nWK3Jql/7NXyBsJDj MFI9pHkT+sR+wYuE0sONmfYvBXIFoDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745948142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTql7HnDsxiIl3qbXiANCn26wibJ3QtLQajx4ncrD2o=; b=FSTCRZ/D/eTka6b0o4j8dV4ATJAhkuUXmNkufZlrkVRi5sLloW76AwhQ0qTudzgxth8daK br45g6Q4KgnaHgDQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745948142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTql7HnDsxiIl3qbXiANCn26wibJ3QtLQajx4ncrD2o=; b=wHgzt1eEZbBCyK8k7Pdyf3ymTbQPGqq4Ga77Y3M9cYGnyeUOuIx/u8xj2Zy9e/e22McJBa Usi8wTXX9hImndCkAHHe5w3vmJXT4utsLFw6rpjUOTJMPwT8KPC59nWK3Jql/7NXyBsJDj MFI9pHkT+sR+wYuE0sONmfYvBXIFoDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745948142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTql7HnDsxiIl3qbXiANCn26wibJ3QtLQajx4ncrD2o=; b=FSTCRZ/D/eTka6b0o4j8dV4ATJAhkuUXmNkufZlrkVRi5sLloW76AwhQ0qTudzgxth8daK br45g6Q4KgnaHgDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 120791340C; Tue, 29 Apr 2025 17:35:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +3y1Au4NEWj4MgAAD6G6ig (envelope-from ); Tue, 29 Apr 2025 17:35:42 +0000 Message-ID: <0d46ca2b-3cb2-48c0-8e6d-989e1e5f9325@suse.de> Date: Tue, 29 Apr 2025 19:35:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme-tcp: select tls config when tcp tls is enabled To: Chaitanya Kulkarni , Alistair Francis , "hch@lst.de" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" Cc: "linux-kernel@vger.kernel.org" , Alistair Francis References: <20250424101333.2908504-1-alistair.francis@wdc.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[nvidia.com,gmail.com,lst.de,grimberg.me,lists.infradead.org]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[7]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[nvidia.com:email,wdc.com:email,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250429_103544_321137_87134B60 X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 4/29/25 18:28, Chaitanya Kulkarni wrote: > On 4/24/25 03:13, Alistair Francis wrote: >> Ensure that TLS support is enabled in the kernel when >> NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be >> used out of the box. >> >> Signed-off-by: Alistair Francis > > Looks good. > > Reviewed-by: Chaitanya Kulkarni > > -ck > Alistair, I think the same fix should be applied to the host side, too; check the last patch of my patch series to convert the authentication code to use the kernel keyring [1]. Should I send out that one as a stand-alone patch to get this issue resolved? [1] https://lore.kernel.org/linux-nvme/20250425094927.102656-13-hare@kernel.org/T/#u Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich