All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Eiden <seiden@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
	kvm390 mailing list  <kvm390-list@tuxmaker.boeblingen.de.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	imbrenda@linux.ibm.com, thuth@redhat.com, nrb@linux.ibm.com,
	scgl@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 2/6] s390x: uv-host: Add uninitialized UV tests
Date: Mon, 16 May 2022 17:34:42 +0200	[thread overview]
Message-ID: <0d5f7fd8-281a-c38a-c922-6a95a5a96ec3@linux.ibm.com> (raw)
In-Reply-To: <9ed77ba2-034a-0278-1416-1b71b9454d8d@linux.ibm.com>

Hi Janosch,

On 5/16/22 17:15, Janosch Frank wrote:
> On 5/16/22 17:02, Steffen Eiden wrote:
>>
[snip]
> [...]
>>>    static void setup_vmem(void)
>>> @@ -514,6 +587,7 @@ int main(void)
>>>        test_priv();
>>>        test_invalid();
>>> +    test_uv_uninitialized();
>>>        test_query();
>>>        test_init();
>> IIRC this test must be done last, as a following test has an
>> uninitialized UV. Maybe add a short comment for that here.
> 
> You're referring to the test_init()?
> 
> The test_clear() function must be done last but you're commenting under 
> the test_init() call. So I'm a bit confused about what you want me to do 
> here.

Sorry, my fault. Yes I wanted to suggest a comment for the 'test_clear' 
function.


  reply	other threads:[~2022-05-16 15:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13  9:50 [kvm-unit-tests PATCH 0/6] s390x: uv-host: Access check extensions and improvements Janosch Frank
2022-05-13  9:50 ` [kvm-unit-tests PATCH 1/6] s390x: uv-host: Add access checks for donated memory Janosch Frank
2022-05-16  8:21   ` Nico Boehr
2022-05-16  9:22     ` Janosch Frank
2022-05-13  9:50 ` [kvm-unit-tests PATCH 2/6] s390x: uv-host: Add uninitialized UV tests Janosch Frank
2022-05-16  8:37   ` Nico Boehr
2022-05-16 15:02   ` Steffen Eiden
2022-05-16 15:15     ` Janosch Frank
2022-05-16 15:34       ` Steffen Eiden [this message]
2022-05-13  9:50 ` [kvm-unit-tests PATCH 3/6] s390x: uv-host: Test uv immediate parameter Janosch Frank
2022-05-17  8:29   ` Steffen Eiden
2022-05-17  9:03     ` Janosch Frank
2022-05-17  9:04       ` Steffen Eiden
2022-05-13  9:50 ` [kvm-unit-tests PATCH 4/6] s390x: uv-host: Add access exception test Janosch Frank
2022-05-16  8:42   ` Nico Boehr
2022-05-17  8:53   ` Steffen Eiden
2022-05-13  9:50 ` [kvm-unit-tests PATCH 5/6] s390x: uv-host: Add a set secure config parameters test function Janosch Frank
2022-05-17 11:32   ` Steffen Eiden
2022-05-13  9:50 ` [kvm-unit-tests PATCH 6/6] s390x: uv-host: Remove duplicated + Janosch Frank
2022-05-13 15:30   ` Claudio Imbrenda
2022-05-17 11:33   ` Steffen Eiden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d5f7fd8-281a-c38a-c922-6a95a5a96ec3@linux.ibm.com \
    --to=seiden@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm390-list@tuxmaker.boeblingen.de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=scgl@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.