From: Pasha Tatashin <Pavel.Tatashin@microsoft.com>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "mhocko@suse.com" <mhocko@suse.com>,
"dave.jiang@intel.com" <dave.jiang@intel.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"dave.hansen@intel.com" <dave.hansen@intel.com>,
"jglisse@redhat.com" <jglisse@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"logang@deltatee.com" <logang@deltatee.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v4 3/5] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap
Date: Fri, 21 Sep 2018 20:14:32 +0000 [thread overview]
Message-ID: <0d9a970c-bec2-e350-be9e-52029282da30@microsoft.com> (raw)
In-Reply-To: <f4d5ace6-9657-746b-9448-064a4b7cfb8d@linux.intel.com>
>>> + page->pgmap = pgmap;
>>> + page->hmm_data = 0;
>>
>> __init_single_page()
>> mm_zero_struct_page()
>>
>> Takes care of zeroing, no need to do another store here.
>
> The problem is __init_singe_page also calls INIT_LIST_HEAD which I
> believe sets the prev pointer which overlaps with hmm_data.
Indeed it does:
INIT_LIST_HEAD(&page->lru); overlaps with hmm_data, and before
list_del(&page->lru); was called to remove from the list.
And now I see you also mentioned about this in comments. I also prefer
having it zeroed instead of left poisoned or uninitialized. The change
looks good.
Thank you,
Pavel
>
>>
>> Looks good otherwise.
>>
>> Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
>>
>
> Thanks for the review.
>
next prev parent reply other threads:[~2018-09-21 20:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 22:24 [PATCH v4 0/5] Address issues slowing persistent memory initialization Alexander Duyck
2018-09-20 22:24 ` Alexander Duyck
2018-09-20 22:26 ` [PATCH v4 1/5] mm: Provide kernel parameter to allow disabling page init poisoning Alexander Duyck
2018-09-20 22:26 ` Alexander Duyck
2018-09-21 19:04 ` Pasha Tatashin
2018-09-21 19:41 ` Logan Gunthorpe
2018-09-21 19:41 ` Logan Gunthorpe
2018-09-21 19:52 ` Pasha Tatashin
2018-09-20 22:27 ` [PATCH v4 2/5] mm: Create non-atomic version of SetPageReserved for init use Alexander Duyck
2018-09-20 22:27 ` Alexander Duyck
2018-09-21 19:06 ` Pasha Tatashin
2018-09-20 22:29 ` [PATCH v4 3/5] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap Alexander Duyck
2018-09-20 22:29 ` Alexander Duyck
2018-09-21 19:50 ` Pasha Tatashin
2018-09-21 20:03 ` Alexander Duyck
2018-09-21 20:03 ` Alexander Duyck
2018-09-21 20:14 ` Pasha Tatashin [this message]
2018-09-20 22:29 ` [PATCH v4 4/5] async: Add support for queueing on specific node Alexander Duyck
2018-09-20 22:29 ` Alexander Duyck
2018-09-21 14:57 ` Dan Williams
2018-09-21 14:57 ` Dan Williams
2018-09-21 17:02 ` Alexander Duyck
2018-09-21 17:02 ` Alexander Duyck
2018-09-29 8:15 ` [LKP] [async] 06f4f5bfb3: BUG:sleeping_function_called_from_invalid_context_at_include/linux/percpu-rwsem.h kernel test robot
2018-09-29 8:15 ` kernel test robot
2018-09-29 8:15 ` kernel test robot
2018-09-20 22:29 ` [PATCH v4 5/5] nvdimm: Schedule device registration on node local to the device Alexander Duyck
2018-09-20 22:29 ` Alexander Duyck
2018-09-20 22:59 ` Dan Williams
2018-09-20 22:59 ` Dan Williams
2018-09-21 0:16 ` Alexander Duyck
2018-09-21 0:16 ` Alexander Duyck
2018-09-21 0:36 ` Dan Williams
2018-09-21 0:36 ` Dan Williams
2018-09-21 1:33 ` Alexander Duyck
2018-09-21 1:33 ` Alexander Duyck
2018-09-21 2:46 ` Dan Williams
2018-09-21 2:46 ` Dan Williams
2018-09-21 14:46 ` Alexander Duyck
2018-09-21 14:46 ` Alexander Duyck
2018-09-21 14:56 ` Dan Williams
2018-09-21 14:56 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d9a970c-bec2-e350-be9e-52029282da30@microsoft.com \
--to=pavel.tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.