Re: [PATCH v3 0/3] drm/sched: Job queue peek/pop helpers and struct job re-order

[Danilo Krummrich <dakr@kernel.org>]

On 2/6/25 5:40 PM, Tvrtko Ursulin wrote:
> Lets add some helpers for peeking and popping from the job queue which allows us
> to re-order the fields in struct drm_sched_job and remove one hole.

I think you forgot to add the dri-devel list.

Can't fetch patches with b4. :(

> 
> v2:
>   * Add header file for internal scheduler API.
>   * Add helper for peeking too. (Danilo)
>   * Add (temporary?) drm_sched_cancel_all_jobs() helper to replace amdgpu
>     amdgpu_job_stop_all_jobs_on_sched().
> 
> v3:
>   * Settle for a copy of __drm_sched_entity_queue_pop in amdgpu for now.
> 
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Philipp Stanner <phasta@kernel.org>
> 
> Tvrtko Ursulin (3):
>    drm/sched: Add internal job peek/pop API
>    drm/amdgpu: Pop jobs from the queue more robustly
>    drm/sched: Remove a hole from struct drm_sched_job
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c    | 22 +++++++++--
>   drivers/gpu/drm/scheduler/sched_entity.c   | 11 +++---
>   drivers/gpu/drm/scheduler/sched_internal.h | 43 ++++++++++++++++++++++
>   drivers/gpu/drm/scheduler/sched_main.c     |  7 ++--
>   include/drm/gpu_scheduler.h                | 38 ++++++++++---------
>   5 files changed, 90 insertions(+), 31 deletions(-)
>   create mode 100644 drivers/gpu/drm/scheduler/sched_internal.h
>