All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Anirban, Sk" <sk.anirban@intel.com>, igt-dev@lists.freedesktop.org
Cc: anshuman.gupta@intel.com, badal.nilawar@intel.com,
	riana.tauro@intel.com, karthik.poosa@intel.com,
	raag.jadav@intel.com, soham.purkait@intel.com,
	mallesh.koujalagi@intel.com, vinay.belgaumkar@intel.com
Subject: Re: [PATCH] tests/intel/xe_pm_residency: Fix suspend duration calculation
Date: Mon, 23 Mar 2026 11:54:28 +0200	[thread overview]
Message-ID: <0df9c0376894cc064be3254fd39b7c52842942ff@intel.com> (raw)
In-Reply-To: <e9e96a80-5a0f-4aad-8b29-e5ff9fd09ddb@intel.com>

On Mon, 23 Mar 2026, "Anirban, Sk" <sk.anirban@intel.com> wrote:
> Hi,
>
> On 23-03-2026 03:00 pm, Jani Nikula wrote:
>> On Mon, 23 Mar 2026, Sk Anirban <sk.anirban@intel.com> wrote:
>>> Fix the unit mismatch caused by interpreting seconds as milliseconds
>>> during suspend duration calculations. Apply MSEC_PER_SEC multiplier
>>> to ensure correct unit handling.
>>>
>> Fixes: ?
> The change is a part of test gap which is filed internally.

No, Fixes: should point at the commit which introduced the use of the
wrong unit in the public repo.

BR,
Jani.


>
> Thanks,
>
> Anirban
>
>>
>>> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
>>> ---
>>>   tests/intel/xe_pm_residency.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
>>> index 61b63ed4f..46718a444 100644
>>> --- a/tests/intel/xe_pm_residency.c
>>> +++ b/tests/intel/xe_pm_residency.c
>>> @@ -223,7 +223,7 @@ static void test_idle_residency(int fd, int gt, enum test_type flag)
>>>   		 * elapsed time during suspend is approximately equal to autoresume delay
>>>   		 * when a full suspend cycle(SUSPEND_TEST_NONE) is used.
>>>   		 */
>>> -		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE);
>>> +		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE) * MSEC_PER_SEC;
>>>   		residency_start = read_idle_residency(fd, gt);
>>>   		igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE, SUSPEND_TEST_NONE);
>>>   		residency_end = read_idle_residency(fd, gt);

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-03-23  9:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  7:02 [PATCH] tests/intel/xe_pm_residency: Fix suspend duration calculation Sk Anirban
2026-03-23  9:30 ` Jani Nikula
2026-03-23  9:41   ` Anirban, Sk
2026-03-23  9:54     ` Jani Nikula [this message]
2026-03-23  9:58       ` Anirban, Sk
2026-03-23 14:12     ` Kamil Konieczny
2026-03-23 10:01 ` Ville Syrjälä
2026-03-23 14:36   ` Anirban, Sk
2026-03-23 15:43     ` Ville Syrjälä
2026-03-23 13:32 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-03-23 15:46 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-23 18:35 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0df9c0376894cc064be3254fd39b7c52842942ff@intel.com \
    --to=jani.nikula@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=soham.purkait@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.