From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6155CC2D0EC for ; Fri, 10 Apr 2020 20:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 350BF206E9 for ; Fri, 10 Apr 2020 20:49:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JYxrDAPP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgDJUtW (ORCPT ); Fri, 10 Apr 2020 16:49:22 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37315 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbgDJUtW (ORCPT ); Fri, 10 Apr 2020 16:49:22 -0400 Received: by mail-lj1-f194.google.com with SMTP id r24so3152467ljd.4; Fri, 10 Apr 2020 13:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RtQay0p36yFoHHnkkvAKDptGQmyg6Qy1Y9oDL+R6OJs=; b=JYxrDAPPO7YcJQGQmfkDNy78riHDRnxnk+1BuPlS7InbdQdxLTvIz8OEPZiFpOU0X9 ADT7Ft9odOWbzW9finqAX/+rKSLfnVSeR5Xa9J4oDuoZc8WSgiBXwkPvTWNMK5QpoSzN 1xg345q38jbniCJJ64eiSGzaeGA44fhbyi5H4thk4LUHgSXt58daDdfyPUcXv+0GjcGe F4H5APl8W/ee6OkZLAkUhs4j7OpWcn9y25FlGh93o4+Mu+UEgQH6tmw2E6EOi8MUeF2i 2aPAZ/DjIos0ISMXOdtcg0a828pLKVjCvFrg05ZPhPQe7PmFCw5csXUaxkljrQ3P9JVy 8uGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RtQay0p36yFoHHnkkvAKDptGQmyg6Qy1Y9oDL+R6OJs=; b=gymH4iAYrdD89KTYxC7WsOj2+8OzRw1wqKWTsYOEDtTAQ/lO0Gc5uA718WquVOybf/ ZDqBc+OOqj+AZJtMesbHUWTt3KooayzWAuuuEJoxG+tvSy3evPfZ4pgTyBRIgz1uUb04 XTXhh8hELz9jNWpVy74l34oonHj4gBFS7ReqP6ILsLebGCL4IdVitzqDxoNBpbDe7O/z smE8L+CUgBrm4SUQlocx3j3YLRzPbCeJqQdleWLHr8tQoiJTFHG9r85IZvUgT3TxKeaf uOaFCVuFYjVPywu3+1V1EGkg+7iQpnxvQQkYBXTwCcMYcYW57uae/ntlmXcxphLB7PrR hDbQ== X-Gm-Message-State: AGi0PuZYmY40FIslkrKFrT/6VwBzsdF15vQjfYdZmrZYEgvM9PwZeP8U DpZGYvK+elY7aLmd9ku2n3U= X-Google-Smtp-Source: APiQypKfmrULbbonnzAShBhrnEqTia/HO1FQk3qKGk14wKYdR6iNAa6QFkvw+u0KqefzQ/PvT2QTPg== X-Received: by 2002:a2e:b4d1:: with SMTP id r17mr3909160ljm.117.1586551760333; Fri, 10 Apr 2020 13:49:20 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id v9sm1775739ljj.31.2020.04.10.13.49.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 13:49:19 -0700 (PDT) Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <0e040cf9-56cf-dd44-3523-ff4c82fb1f2c@gmail.com> Date: Fri, 10 Apr 2020 23:49:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-8-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > +int tegra210_clk_emc_attach(struct clk *clk, > + struct tegra210_clk_emc_provider *provider) > +{ > + struct clk_hw *hw = __clk_get_hw(clk); > + struct tegra210_clk_emc *emc = to_tegra210_clk_emc(hw); > + struct device *dev = provider->dev; > + unsigned int i; > + int err; > + > + if (!try_module_get(provider->owner)) > + return -ENODEV; Is the EMC driver module bumping its own refcount by itself? In the other patch I already suggested that the EMC module should be disallowed to be unloaded once it has been loaded, seems you're already doing it. Correct? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock Date: Fri, 10 Apr 2020 23:49:18 +0300 Message-ID: <0e040cf9-56cf-dd44-3523-ff4c82fb1f2c@gmail.com> References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200409175238.3586487-8-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > +int tegra210_clk_emc_attach(struct clk *clk, > + struct tegra210_clk_emc_provider *provider) > +{ > + struct clk_hw *hw = __clk_get_hw(clk); > + struct tegra210_clk_emc *emc = to_tegra210_clk_emc(hw); > + struct device *dev = provider->dev; > + unsigned int i; > + int err; > + > + if (!try_module_get(provider->owner)) > + return -ENODEV; Is the EMC driver module bumping its own refcount by itself? In the other patch I already suggested that the EMC module should be disallowed to be unloaded once it has been loaded, seems you're already doing it. Correct? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84202C2D0EC for ; Fri, 10 Apr 2020 20:49:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B488206E9 for ; Fri, 10 Apr 2020 20:49:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BU6glovB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JYxrDAPP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B488206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8snBBS3nlcv5PecqppMb3PB22OPvr38eOy8szOUtXXw=; b=BU6glovByfqzgt tNCDWXeju4i0AgBV5emrh+MgQbhZWd/37QBRClVGez3dqcm6DXkZk41h/TLurUboCMLJb872540dw g5PTqUAf1NfPfqqL24YICr4n+SAUsZKUDFZMM16APMXvP5woKj5oFGqF6vN6TVMFq+Dl2tcU0NCGO Xv70FS+y9kBWSFz1ipF593X3B+nEz2RszjLm2qsLko5u2yuxZP6fNFiYAH9TBSe9aUT/eWbDOUfle uw4uTWQkvnHsIRTWSo0FLgkW93Q2p3MyOLo/anFQaAPAcsCS0Bt2ehiTFQWZzvaY4AhdEhv28+BWG TL/m2eUQ+zRIYaHv74Ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jN0ab-0004mA-0P; Fri, 10 Apr 2020 20:49:25 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jN0aY-0004lV-EV for linux-arm-kernel@lists.infradead.org; Fri, 10 Apr 2020 20:49:23 +0000 Received: by mail-lj1-x242.google.com with SMTP id n17so3122246lji.8 for ; Fri, 10 Apr 2020 13:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RtQay0p36yFoHHnkkvAKDptGQmyg6Qy1Y9oDL+R6OJs=; b=JYxrDAPPO7YcJQGQmfkDNy78riHDRnxnk+1BuPlS7InbdQdxLTvIz8OEPZiFpOU0X9 ADT7Ft9odOWbzW9finqAX/+rKSLfnVSeR5Xa9J4oDuoZc8WSgiBXwkPvTWNMK5QpoSzN 1xg345q38jbniCJJ64eiSGzaeGA44fhbyi5H4thk4LUHgSXt58daDdfyPUcXv+0GjcGe F4H5APl8W/ee6OkZLAkUhs4j7OpWcn9y25FlGh93o4+Mu+UEgQH6tmw2E6EOi8MUeF2i 2aPAZ/DjIos0ISMXOdtcg0a828pLKVjCvFrg05ZPhPQe7PmFCw5csXUaxkljrQ3P9JVy 8uGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RtQay0p36yFoHHnkkvAKDptGQmyg6Qy1Y9oDL+R6OJs=; b=gZcxI9m9tWp9IokVStgqPNjQUSUOP+tg/WhqFOPIyKSFEUG+bU0Mi9j1N75l5nLMgu MPSMM7KVomwz10o/dgZDKuXVkWHQtN8wG3bfQFkCs1gtFnVX8h5KhFAncBcdfvsQolOO NmQQ2fHV9KDN9kRdJwQ+zJxvRBCpGuCc6kpFOp2S+lwZbK8GvoSK5dJfeju55Mc6RgJq gGl7COoiqhhx3rQKUKGupU9fXu0tUfAvo12mwx4yKFesICLP/zBrbUwvkS+e9+SVmVo6 4L6NN3DZxtxcYXDGnWqgYctH1JWROmfoIeqUVPkfQqlJWitkhcaCmTEcX8s3115oS/vB 2suw== X-Gm-Message-State: AGi0PuY8JvtzRki8/ZVXRAeLLpD6nHv+iZRyHxRBkMF/37rhSKk/Vsqm DR/lF4WbISPLFY03VPOJBuh2nuXJ X-Google-Smtp-Source: APiQypKfmrULbbonnzAShBhrnEqTia/HO1FQk3qKGk14wKYdR6iNAa6QFkvw+u0KqefzQ/PvT2QTPg== X-Received: by 2002:a2e:b4d1:: with SMTP id r17mr3909160ljm.117.1586551760333; Fri, 10 Apr 2020 13:49:20 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id v9sm1775739ljj.31.2020.04.10.13.49.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 13:49:19 -0700 (PDT) Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock To: Thierry Reding , Rob Herring References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <0e040cf9-56cf-dd44-3523-ff4c82fb1f2c@gmail.com> Date: Fri, 10 Apr 2020 23:49:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-8-thierry.reding@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200410_134922_483105_6DFACDC1 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDkuMDQuMjAyMCAyMDo1MiwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKLi4uCj4gK2ludCB0 ZWdyYTIxMF9jbGtfZW1jX2F0dGFjaChzdHJ1Y3QgY2xrICpjbGssCj4gKwkJCSAgICBzdHJ1Y3Qg dGVncmEyMTBfY2xrX2VtY19wcm92aWRlciAqcHJvdmlkZXIpCj4gK3sKPiArCXN0cnVjdCBjbGtf aHcgKmh3ID0gX19jbGtfZ2V0X2h3KGNsayk7Cj4gKwlzdHJ1Y3QgdGVncmEyMTBfY2xrX2VtYyAq ZW1jID0gdG9fdGVncmEyMTBfY2xrX2VtYyhodyk7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBw cm92aWRlci0+ZGV2Owo+ICsJdW5zaWduZWQgaW50IGk7Cj4gKwlpbnQgZXJyOwo+ICsKPiArCWlm ICghdHJ5X21vZHVsZV9nZXQocHJvdmlkZXItPm93bmVyKSkKPiArCQlyZXR1cm4gLUVOT0RFVjsK CklzIHRoZSBFTUMgZHJpdmVyIG1vZHVsZSBidW1waW5nIGl0cyBvd24gcmVmY291bnQgYnkgaXRz ZWxmPwoKSW4gdGhlIG90aGVyIHBhdGNoIEkgYWxyZWFkeSBzdWdnZXN0ZWQgdGhhdCB0aGUgRU1D IG1vZHVsZSBzaG91bGQgYmUKZGlzYWxsb3dlZCB0byBiZSB1bmxvYWRlZCBvbmNlIGl0IGhhcyBi ZWVuIGxvYWRlZCwgc2VlbXMgeW91J3JlIGFscmVhZHkKZG9pbmcgaXQuIENvcnJlY3Q/CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==