From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf] bpf: btf: Ensure the member->offset is in the right
 order
Date: Mon, 23 Jul 2018 11:45:05 -0700
Message-ID: <0e0a30fe-e1af-681c-2ccd-e9db91d5246f@fb.com>
References: <20180721003837.2772516-1-kafai@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexei Starovoitov <ast@fb.com>,
        Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>
To: Martin KaFai Lau <kafai@fb.com>, <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:58422 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S2388054AbeGWTsG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 23 Jul 2018 15:48:06 -0400
In-Reply-To: <20180721003837.2772516-1-kafai@fb.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 7/20/18 5:38 PM, Martin KaFai Lau wrote:
> This patch ensures the member->offset of a struct
> is in the correct order (i.e the later member's offset cannot
> go backward).
> 
> The current "pahole -J" BTF encoder does not generate something
> like this.  However, checking this can ensure future encoder
> will not violate this.
> 
> Fixes: 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)")
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Yonghong Song <yhs@fb.com>