Re: [meta-raspberrypi][PATCH 4/5] pitft: Add basic support for PiTFT

["Petter Mabäcker" <petter@technux.se>]

[-- Attachment #1: Type: text/plain, Size: 2751 bytes --]

 

2016-01-12 09:45 skrev Khem Raj: 

> On Mon, Jan 11, 2016 at 10:51
PM, Petter Mabäcker <petter@technux.se> wrote:
> 
>> 2016-01-11 21:32
skrev Andrei Gherzan: On Mon, Jan 11, 2016 at 09:55:43AM -0800, Khem Raj
wrote: On Jan 11, 2016, at 8:49 AM, Petter Mabäcker <petter@technux.se>
wrote: Add basic support for PiTFT display by using device-trees. In
order get it working below configurations must be active in local.conf:
MACHINEOVERRIDES .= ":pitft" Using MACHINE_FEATURES will be more
appropriate term. Effects are same. Indeed. I support MACHINE_FEATURE
usage here. I agree that the term MACHINE_FEATURES is better. However
since MACHINE_FEATURES isn't included in the OVERRIDES variable I will
not be able to use the task pre/appends that was the reason I used
MACHINEOVERRIDES in the first place. The reason I want to use overrides
in this case is since I think it makes the code easier to read and
understand for the user (in this particular case at least). I can of
course change to just using variables (like in many other optional
features in meta-raspberrypi) or change to MACHINE_FEATURES. But I'm not
sure how I can solve for example the below part in a effective and nice
way:
> 
> it really doesnt need to have override, you can enquire
>
MACHINE_FEATURES in python or shell.

Yes, I'm aware of that I can use
it that way. It was just my personal opinion that the code looks better
with overrides in this particular case. On the other hand I can agree
that the end-user will be more comfortable with using MACHINE_FEATURES
instead of MACHINEOVERRIDES. Also since both you and Andrei push for
MACHINE_FEATURES I will bend for your will =) 

Start using
MACHINE_FEATURES from local.conf when using meta-raspberrypi will
require a minor change i rpi-base.inc as well, since it otherwise will
override MACHINE_FEATURES added in local.conf. I will send up a fix for
that in v2 of this series as well. 

Thanks for your feedback. 

BR
Petter 

>> xserver-xf86-config_0.1.bbappend FILESEXTRAPATHS_prepend :=
"${THISDIR}/${PN}:" SRC_URI_append_rpi = "
file://xorg.conf.d/10-evdev.conf [1] " SRC_URI_append_pitft = "
file://xorg.conf.d/99-pitft.conf [2] " <---------------- My change....
do_install_append_rpi () { install -d
${D}/${sysconfdir}/X11/xorg.conf.d/ install -m 0644
${WORKDIR}/xorg.conf.d/* ${D}/${sysconfdir}/X11/xorg.conf.d/ }
FILES_${PN}_rpi += "${sysconfdir}/X11/xorg.conf
${sysconfdir}/X11/xorg.conf.d/*" ------------------- end
----------------------- But if you have any good suggestions about how
to solve this, please enlighten me =) BR Petter -- Andrei Gherzan



Links:
------
[1] file://xorg.conf.d/10-evdev.conf
[2]
file://xorg.conf.d/99-pitft.conf

[-- Attachment #2: Type: text/html, Size: 3524 bytes --]