From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v3 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos Date: Wed, 24 Jul 2013 16:55:16 +0900 Message-ID: <0e8401ce8843$22817960$67846c20$@org> References: <1374636693-32336-1-git-send-email-sachin.kamat@linaro.org> <0e4301ce8835$f5bef5e0$e13ce1a0$@org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:28375 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800Ab3GXHzS (ORCPT ); Wed, 24 Jul 2013 03:55:18 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQF0050VKO4SEF0@mailout3.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 24 Jul 2013 16:55:16 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Sachin Kamat' Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org, 'Tomasz Figa' Sachin Kamat wrote: > > On 24 July 2013 11:50, Kukjin Kim wrote: > > Sachin Kamat wrote: > >> > >> With the recent cleanup in Exynos platform code notably commits > >> 17859bec ("ARM: EXYNOS: Do not select legacy Kconfig symbols any > >> more") and b9222210 ("ARM: EXYNOS: Remove mach/gpio.h"), the definition > >> of ARCH_NR_GPIOS got removed. This started causing problems on SoCs > like > >> Exynos4412 which have more than the default number of GPIOs. Thus > define > >> this number in KConfig file which takes care of current SoC > requirements > >> and provides scope for GPIO expanders. Without this patch we get the > >> following > >> errors during boot: > >> > >> gpiochip_add: gpios 251..258 (gpv0) failed to register > >> samsung-pinctrl 106e0000.pinctrl: failed to register gpio_chip gpv0, > >> error code: -22 > >> samsung-pinctrl: probe of 106e0000.pinctrl failed with error -22 > >> > >> Signed-off-by: Sachin Kamat > >> Cc: Tomasz Figa > >> --- > >> Changes since v2: > >> Changed the default number to 512 to accomodate GPIO exapnders. > >> --- > >> arch/arm/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index ccc388d..b3c4fa4 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -1601,6 +1601,7 @@ config ARCH_NR_GPIO > >> int > >> default 1024 if ARCH_SHMOBILE || ARCH_TEGRA > >> default 512 if SOC_OMAP5 > >> + default 512 if ARCH_EXYNOS > >> default 512 if ARCH_KEYSTONE > > > > + default 512 if ARCH_EXYNOS || ARCH_KEYSTONE || SOC_OMAP5 ? > > Looks good. Do you want me to re-send this? > Yes, please. - Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene@kernel.org (Kukjin Kim) Date: Wed, 24 Jul 2013 16:55:16 +0900 Subject: [PATCH v3 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos In-Reply-To: References: <1374636693-32336-1-git-send-email-sachin.kamat@linaro.org> <0e4301ce8835$f5bef5e0$e13ce1a0$@org> Message-ID: <0e8401ce8843$22817960$67846c20$@org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sachin Kamat wrote: > > On 24 July 2013 11:50, Kukjin Kim wrote: > > Sachin Kamat wrote: > >> > >> With the recent cleanup in Exynos platform code notably commits > >> 17859bec ("ARM: EXYNOS: Do not select legacy Kconfig symbols any > >> more") and b9222210 ("ARM: EXYNOS: Remove mach/gpio.h"), the definition > >> of ARCH_NR_GPIOS got removed. This started causing problems on SoCs > like > >> Exynos4412 which have more than the default number of GPIOs. Thus > define > >> this number in KConfig file which takes care of current SoC > requirements > >> and provides scope for GPIO expanders. Without this patch we get the > >> following > >> errors during boot: > >> > >> gpiochip_add: gpios 251..258 (gpv0) failed to register > >> samsung-pinctrl 106e0000.pinctrl: failed to register gpio_chip gpv0, > >> error code: -22 > >> samsung-pinctrl: probe of 106e0000.pinctrl failed with error -22 > >> > >> Signed-off-by: Sachin Kamat > >> Cc: Tomasz Figa > >> --- > >> Changes since v2: > >> Changed the default number to 512 to accomodate GPIO exapnders. > >> --- > >> arch/arm/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index ccc388d..b3c4fa4 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -1601,6 +1601,7 @@ config ARCH_NR_GPIO > >> int > >> default 1024 if ARCH_SHMOBILE || ARCH_TEGRA > >> default 512 if SOC_OMAP5 > >> + default 512 if ARCH_EXYNOS > >> default 512 if ARCH_KEYSTONE > > > > + default 512 if ARCH_EXYNOS || ARCH_KEYSTONE || SOC_OMAP5 ? > > Looks good. Do you want me to re-send this? > Yes, please. - Kukjin